-
Notifications
You must be signed in to change notification settings - Fork 7
Refactor CMake with JRL CMake Modules v2 (v2) #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahoarau
wants to merge
59
commits into
Simple-Robotics:main
Choose a base branch
from
ahoarau:jrl-next-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
9eb68e6
cpp: remove unused macros in fwd.hpp
ahoarau febe629
cpp: add dependency headers wrt a compile def
ahoarau 3328fb7
cpp: merge internal.h into module.cpp
ahoarau 7c87c21
python: migrate tests to pytest
ahoarau c2f389f
gersemi: update config
ahoarau 540360f
pixi.toml: we can use forward slash in windows
ahoarau 0ed34d7
pixi.toml: add install and test commands
ahoarau ffdd548
pixi.toml: add explicit testing, and build type
ahoarau d8febdf
git: remove submodules
ahoarau 10580b4
gitignore: ignore more stuff
ahoarau b1c4dc5
cmake: refactor CMake files with JRL CMake Modules v2
ahoarau 52801e6
cmake: intregrate get-jrl-cmakemodules.cmake
ahoarau 39e264b
cmake: format tests/CMakeLists.txt (remove gersemi off/on)
ahoarau c483be6
cmake: update jrl url to point to fork
ahoarau bcc5e23
cmake: require jrl-cmakemodules version 2.0.0
ahoarau 865159c
cmake: rename test dir
ahoarau 6e10c7a
cmake: require at least nanobind 2.5.0
ahoarau 258d5fb
cmake: change message verbosity to STATUS and fix env case
ahoarau 75cbf86
cmake: add debug messages to explain what we do with nanobind
ahoarau 74ad0fd
ci: add debug and verbose output to ros ci
ahoarau d31d399
ci: use the commands defined in pixi.toml
ahoarau d288808
pixi.toml: add pytest
ahoarau 1955038
pixi.toml: remove extra cmake lines in configure task
ahoarau 892fa89
pixi.toml: add test packaging
ahoarau 5d04192
pixi.toml: override python install dir on windows
ahoarau 2defd48
changelog: update with jrl v2
ahoarau aeec293
ci: temporarly disable nix job
ahoarau 6390017
gitignore: ignore ruff cache
ahoarau 2e71ece
ci: disable nix job check
ahoarau 04b8919
cmake: add check for the quaternion test module
ahoarau 87fc9db
cmake: add inria copyright
ahoarau d00ff18
cmake: remove cmake version range
ahoarau 7a9a457
cmake: update nanobind GIT_TAG to v2.10.2
ahoarau 21d68a5
ci: remove warning by passing the explicit arguments to env
ahoarau 4389ad8
ci: remove explicit cache for pixi
ahoarau 9b7a576
ci: cosmetics on pixi job
ahoarau 7cf7101
ci: rosci enable cache and prerelease
ahoarau a42634c
package.xml: nanobind-dev not yet available
ahoarau 1cce9dc
ci: ros ci disable fail fast
ahoarau 19a5acb
package.xml: add pytest dep
ahoarau 1f48b44
ci: name the ros jobs
ahoarau cf2c309
rosci: configure cache
ahoarau b1656c5
ci: relax cache availability
ahoarau b708261
cmale: update cmake option docs
ahoarau c99ebbd
changelog: remove the c++17 required.
ahoarau 3ad885b
cmake: move dependencies to headers instead of module
ahoarau e7f3181
cmake: add jrl_generate_ros2_package_files
ahoarau 005ba99
cmake: update jrl_target_generate_header API
ahoarau 1bf6e3d
ci: display more info before clearing ccache cache
ahoarau 60d805a
rosci: do not use prerelease
ahoarau 1aee740
cmake: update the get-jrl messages
ahoarau dc2ed59
cmake: require jrl >=1.2 to get the jrl-v2
ahoarau 0deb612
cmake: update python and nanobind min required
ahoarau 2f6f661
pixi: remove the custom python install dir for pixi build
ahoarau f877e0d
cmake: include project version in config header generation
ahoarau a7a86a6
pixi.toml: re-enable pixi build
ahoarau 60b2d5d
cmake: format
ahoarau 3670fd9
ci: comment out pixi build
ahoarau a747b22
pixi: update lock file
ahoarau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| definitions: [./CMakeLists.txt, ./cmake, ./tests] | ||
| line_length: 80 | ||
| definitions: [./CMakeLists.txt, ./tests] | ||
| line_length: 100 | ||
| indent: 2 | ||
| warn_about_unknown_commands: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -20,34 +20,50 @@ concurrency: | |||||||||
| cancel-in-progress: true | ||||||||||
|
|
||||||||||
| jobs: | ||||||||||
| CI: | ||||||||||
| ros: | ||||||||||
| name: ROS ${{ matrix.ROS_DISTRO }} - ${{ matrix.os }} | ||||||||||
| strategy: | ||||||||||
| fail-fast: false | ||||||||||
| matrix: | ||||||||||
| env: | ||||||||||
| - {ROS_DISTRO: humble} | ||||||||||
| - {ROS_DISTRO: jazzy} | ||||||||||
| - {ROS_DISTRO: kilted} | ||||||||||
| - {ROS_DISTRO: rolling} | ||||||||||
| include: | ||||||||||
| # ROS2 Humble Hawksbill (May 2022 - May 2027) | ||||||||||
| - ROS_DISTRO: humble | ||||||||||
| os: Ubuntu 22.04 (Jammy) | ||||||||||
|
|
||||||||||
| # ROS2 Jazzy Jalisco (May 2024 - May 2029) | ||||||||||
| - ROS_DISTRO: jazzy | ||||||||||
| os: Ubuntu 24.04 (Noble) | ||||||||||
|
|
||||||||||
| # ROS2 Kilted Kayu (May 2025 - December 2026) | ||||||||||
| - ROS_DISTRO: kilted | ||||||||||
| os: Ubuntu 24.04 (Noble) | ||||||||||
|
|
||||||||||
| # ROS2 Rolling Ridley | ||||||||||
| - ROS_DISTRO: rolling | ||||||||||
| os: Ubuntu 24.04 (Noble) | ||||||||||
| env: | ||||||||||
| # PRERELEASE: true # Fails due to issues in the underlying Docker image | ||||||||||
| BUILDER: colcon | ||||||||||
| VERBOSE_OUTPUT: true | ||||||||||
| VERBOSE_TESTS: true | ||||||||||
| ROS_DISTRO: ${{ matrix.ROS_DISTRO }} | ||||||||||
| CCACHE_DIR: ${{ github.workspace }}/.ccache | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| steps: | ||||||||||
| - uses: actions/checkout@v6 | ||||||||||
| - uses: actions/cache@v4 | ||||||||||
| with: | ||||||||||
| submodules: recursive | ||||||||||
| # Run industrial_ci | ||||||||||
| - uses: 'ros-industrial/industrial_ci@c553397753252d630e88e7e91aa69c6c8a478ee0' | ||||||||||
| env: ${{ matrix.env }} | ||||||||||
| path: ${{ env.CCACHE_DIR }} | ||||||||||
| key: ccache-${{ matrix.ROS_DISTRO }}-${{github.run_id}} | ||||||||||
| restore-keys: ccache-${{ matrix.ROS_DISTRO }}- | ||||||||||
|
Comment on lines
+55
to
+56
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
| - uses: 'ros-industrial/industrial_ci@ba2a3d0f830f8051b356711a8df2fedfc5d256cf' | ||||||||||
|
|
||||||||||
| check: | ||||||||||
| if: always() | ||||||||||
| name: check-ros-ci | ||||||||||
|
|
||||||||||
| needs: | ||||||||||
| - CI | ||||||||||
| - ros | ||||||||||
|
|
||||||||||
| runs-on: Ubuntu-latest | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| - name: Decide whether the needed jobs succeeded or failed | ||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,16 @@ | ||
| build*/ | ||
| install*/ | ||
| .pytest_cache/ | ||
| .cache/ | ||
| __pycache__ | ||
| .pytest_cache | ||
|
|
||
| # pixi environments | ||
| .pixi | ||
| .pixi/ | ||
| __pycache__/ | ||
| Xcode* | ||
| *.pyc | ||
| *~ | ||
| *.egg-info | ||
| .ruff_cache/ | ||
| .DS_Store | ||
| compile_commands.json | ||
| cmake-profiling.json | ||
| result | ||
| *.conda |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -16,6 +16,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||||||||||||
| - Python version update ([#25](https://github.com/Simple-Robotics/nanoeigenpy/pull/25)): | ||||||||||||||
| - Project is now tested with Python 3.10 and 3.14 | ||||||||||||||
| - Python 3.10 is the minimal supported Python version | ||||||||||||||
| - Switch to [JRL CMake modules v2](https://github.com/jrl-umi3218/jrl-cmakemodules/pull/798) ([#28](https://github.com/Simple-Robotics/nanoeigenpy/pull/28)) | ||||||||||||||
| - Remove submodules: archives can now be used | ||||||||||||||
| - Migrate python tests to pytest | ||||||||||||||
|
Comment on lines
+19
to
+21
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| ### Added | ||||||||||||||
| - Add pixi-build support ([#25](https://github.com/Simple-Robotics/nanoeigenpy/pull/25)) | ||||||||||||||
|
|
||||||||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ${{ matrix.environment }}