Add scaffold surface support for URIS valves#569
Open
hanzhao2020 wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 69.44% 69.51% +0.06%
==========================================
Files 181 181
Lines 34072 34153 +81
Branches 5930 5947 +17
==========================================
+ Hits 23662 23741 +79
- Misses 10273 10275 +2
Partials 137 137 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ktbolt
requested changes
Jun 19, 2026
ktbolt
reviewed
Jun 22, 2026
ktbolt
left a comment
Collaborator
There was a problem hiding this comment.
@hanzhao2020 These changes look good !
However, there are still lots of messages printed to std::cout in uris.cpp; please replace those with DebugMsg calls.
Contributor
Author
@ktbolt Sounds good! Replaced all the URIS printed messages with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #566
Release Notes
Scaffold_file_pathTesting
Code of Conduct & Contributing Guidelines