Skip to content

Add scaffold surface support for URIS valves#569

Open
hanzhao2020 wants to merge 5 commits into
SimVascular:mainfrom
hanzhao2020:add-valve-scaffold
Open

Add scaffold surface support for URIS valves#569
hanzhao2020 wants to merge 5 commits into
SimVascular:mainfrom
hanzhao2020:add-valve-scaffold

Conversation

@hanzhao2020

Copy link
Copy Markdown
Contributor

Resolves #566

Release Notes

  • Added optional scaffold surface support to URIS valve via Scaffold_file_path
  • Computed scaffold surface unsigned distance function (UDF) on fluid nodes using existing URIS SDF routines
  • Scaffold surfaces remain fixed during the simulation and add a resistive force to the fluid

Testing

  • Updated the URIS CFD test case to include a scaffold surface

Code of Conduct & Contributing Guidelines

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.83544% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.51%. Comparing base (9632608) to head (c1703eb).

Files with missing lines Patch % Lines
Code/Source/solver/uris.cpp 95.90% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   69.44%   69.51%   +0.06%     
==========================================
  Files         181      181              
  Lines       34072    34153      +81     
  Branches     5930     5947      +17     
==========================================
+ Hits        23662    23741      +79     
- Misses      10273    10275       +2     
  Partials      137      137              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread Code/Source/solver/uris.cpp
Comment thread Code/Source/solver/uris.cpp Outdated
Comment thread Code/Source/solver/uris.cpp Outdated

@ktbolt ktbolt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanzhao2020 These changes look good !

However, there are still lots of messages printed to std::cout in uris.cpp; please replace those with DebugMsg calls.

@hanzhao2020

Copy link
Copy Markdown
Contributor Author

@hanzhao2020 These changes look good !

However, there are still lots of messages printed to std::cout in uris.cpp; please replace those with DebugMsg calls.

@ktbolt Sounds good! Replaced all the URIS printed messages with DebugMsg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for scaffold surfaces in URIS valves

2 participants