Skip to content

Deleting unused code in TTP ionic model#568

Merged
javijv4 merged 1 commit into
SimVascular:mainfrom
javijv4:dev_ttpj_567
Jun 18, 2026
Merged

Deleting unused code in TTP ionic model#568
javijv4 merged 1 commit into
SimVascular:mainfrom
javijv4:dev_ttpj_567

Conversation

@javijv4

@javijv4 javijv4 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Current situation

Resolves #567

Release Notes

  • Use of Crank-Nicolson with TTP now fails with the Not implemented Exception in ionic_model.h.

Testing

This was dead code, not being tested. All tests still pass.

Code of Conduct & Contributing Guidelines

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@javijv4 javijv4 requested review from ktbolt and michelebucelli June 18, 2026 18:56
@javijv4 javijv4 self-assigned this Jun 18, 2026
@javijv4 javijv4 requested a review from kko27 June 18, 2026 18:56
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.44%. Comparing base (5118d56) to head (edc4a7b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   69.08%   69.44%   +0.36%     
==========================================
  Files         181      181              
  Lines       34256    34072     -184     
  Branches     5931     5930       -1     
==========================================
- Hits        23665    23662       -3     
+ Misses      10454    10273     -181     
  Partials      137      137              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ktbolt ktbolt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javijv4 Looks good !

@kko27 kko27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@michelebucelli michelebucelli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@javijv4 javijv4 merged commit 9632608 into SimVascular:main Jun 18, 2026
8 checks passed
@javijv4 javijv4 deleted the dev_ttpj_567 branch June 18, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in TTP ionic model jacobian

4 participants