Skip to content

Include valve velocity in the URIS valve implementation#565

Merged
ktbolt merged 15 commits into
SimVascular:mainfrom
hanzhao2020:add-uris-velocity
Jun 11, 2026
Merged

Include valve velocity in the URIS valve implementation#565
ktbolt merged 15 commits into
SimVascular:mainfrom
hanzhao2020:add-uris-velocity

Conversation

@hanzhao2020

Copy link
Copy Markdown
Contributor

Resolves #558

Release Notes

  • Computed valve velocity $u_{\Gamma}$ from prescribed valve motion using finite differences
  • Included valve velocity $u_{\Gamma}$ in the URIS force term $f_{RIS} = R {\delta} (u - u_{\Gamma})$
  • Added an optional input argument Include_URIS_velocity to enable inclusion of valve velocity. The default is false

Testing

  • Updated the URIS CFD test case reference results with valve velocity enabled. All tests passed

Code of Conduct & Contributing Guidelines

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.38318% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.08%. Comparing base (ce393a2) to head (554638e).

Files with missing lines Patch % Lines
Code/Source/solver/uris.cpp 81.20% 25 Missing ⚠️
Code/Source/solver/fluid.cpp 96.55% 1 Missing ⚠️
Code/Source/solver/fsi.cpp 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
+ Coverage   69.03%   69.08%   +0.04%     
==========================================
  Files         181      181              
  Lines       34131    34256     +125     
  Branches     5901     5931      +30     
==========================================
+ Hits        23564    23665     +101     
- Misses      10430    10454      +24     
  Partials      137      137              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread Code/Source/solver/ComMod.h Outdated
Comment thread Code/Source/solver/fluid.cpp Outdated
Comment thread Code/Source/solver/fluid.cpp Outdated
Comment thread Code/Source/solver/fluid.cpp Outdated
Comment thread Code/Source/solver/uris.cpp
Comment thread Code/Source/solver/uris.cpp Outdated
Comment thread Code/Source/solver/fluid.cpp Outdated
Comment thread Code/Source/solver/fluid.cpp Outdated
Comment thread tests/cases/uris/pipe_uris_cfd/result_005.vtu Outdated
Comment thread tests/cases/uris/pipe_uris_cfd/solver.xml
Comment thread tests/cases/uris/pipe_uris_cfd/result_005.vtu Outdated
Comment thread Code/Source/solver/uris.cpp

@aabrown100-git aabrown100-git left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending my minor comment about the utilities README

Comment thread utilities/README.md
Comment thread Code/Source/solver/uris.cpp

@ktbolt ktbolt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@ktbolt ktbolt merged commit 5118d56 into SimVascular:main Jun 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Including valve velocity in the URIS valve implementation

3 participants