Skip to content

Stabilize signed-in auth subtree and Google One Tap initialization #90

Closed

Description

@sarthakagrawal927

Reader's signed-in entry can remount its auth subtree and initialize Google One Tap more than once when the login view changes. Preserve the existing landing-to-app design and one explicit sign-in action while keeping auth state stable across ordinary route and loading transitions.

Acceptance:

  • Reuse one One Tap initialization and avoid duplicate prompts or handlers.
  • Keep the auth provider mounted while its client state updates; preserve the current login layout and copy.
  • Cover provider/client behavior and the browser entry flow with deterministic tests.
  • Review the rendered login flow at mobile and desktop widths.

The source candidate was produced in a cloud task and transferred with verified Git bundle provenance. Its parent is the merged Reader PR #89 head (4c45b25). Source PR #91 now contains the original cloud commit and local test/copy fixes; exact-head CI and external Workers Builds checks passed. Local full quality and responsive One Tap browser replay passed. Production deployment and live sign-in remain unverified, so keep this issue open until release qualification.

Related portfolio continuity work: sass-maker/saas-maker#243.

Activity

  1. sarthakagrawal927 commented on Oct 14, 2026

    @sarthakagrawal927
    MemberAuthor

    PR #91 merged to main as 0e6dca693ff9df1f00e14123829f05ab96c5f065. Exact-main CI and the Cloudflare Workers Builds check passed. Wrangler reports production deployment 5a5ea73a-efd0-401c-9f6e-00db64b8011c serving version 5aa43920-c529-479b-b751-d8a6ddfec7b5 at 100% traffic since 2026-10-14 08:45 UTC. That version has no workers/tag SHA annotation, so provider source parity is correlated by the exact-main build check rather than independently established from the version metadata.

    A clean Chromium session loaded the public /login page (HTTP 200), reached the existing “Sign in with Google” action without page/request errors, and showed no horizontal overflow at 390px. The authenticated Google callback and preserved signed-in state were not exercised with a real account. Keep this issue open for that live sign-in acceptance check; source tests and release checks are complete.

  2. sarthakagrawal927 commented on Oct 14, 2026

    @sarthakagrawal927
    MemberAuthor

    Live production sign-in acceptance completed on October 14. From /login, the existing Google action returned to /library under the owner account, where the saved-link inbox rendered its two existing links. Navigation to Connections and back preserved the signed-in session and inbox; a hard reload did too. No link or read-state records were changed. PR #91 was already merged, exact-main CI and Workers Builds passed, and Wrangler reports the deployed version at 100% as recorded above. A Google GSI FedCM AbortError still appeared in the browser console after reload, without disrupting the signed-in flow; the broader cross-product FedCM investigation remains in sass-maker/ui-library#12. This closure qualifies the requested Reader auth flow, not a general claim that Google emits no diagnostics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions