feat: expose acquisition error log via RawFile.error_log()#15
Merged
Conversation
The Rust core already decodes the acquisition error log
(RawFileReader::error_log: Vec<ErrorEntry>) but none of it was surfaced
to Python. Adds RawFile.error_log() returning a list of
{"time": ..., "message": ...} dicts in log order.
Closes Sigilweaver#9
There was a problem hiding this comment.
Pull request overview
This PR exposes the Rust core’s already-decoded acquisition error log (RawFileReader::error_log) through the Python bindings as a new RawFile.error_log() method, and documents the addition in the changelog.
Changes:
- Added
RawFile.error_log()to the PyO3 bindings, returning a list of{"time": ..., "message": ...}dicts in log order. - Updated
CHANGELOG.mdunder## [Unreleased]to describe the new Python API.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/opentfraw-py/src/lib.rs | Adds a new PyO3-exposed RawFile.error_log() method that converts RawFileReader.error_log entries into Python dicts. |
| CHANGELOG.md | Documents the new Python binding API in the Unreleased “Added” section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # CHANGELOG.md
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
opentfraw-docs | f759959 | Jul 08 2026, 11:40 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RawFile.error_log()(Python), returning the already-decodedacquisition error log (
RawFileReader::error_log: Vec<ErrorEntry>) as alist of
{"time": ..., "message": ...}dicts, in log order.timeis theacquisition-relative time in minutes.
CHANGELOG.mdunder## [Unreleased].Test plan
cargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo test --allpytestagainst.Closes #9