fix: add local PWA icons and manifest assets#163
Open
uv05709 wants to merge 8 commits into
Open
Conversation
Owner
|
This branch has conflicts that must be resolved |
uv05709
commented
May 24, 2026
uv05709
left a comment
Contributor
Author
There was a problem hiding this comment.
i view all things it is totally fine
Owner
|
his branch has conflicts that must be resolved icons/icon-192x192.png |
Contributor
Author
|
hey @Shruti070107 i have change fix the image due to my local image is duplicating i deleted those 5 image previouly i didnt saw but not all things are clear |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Description
This PR fixes the broken PWA installability issue caused by missing local icon assets referenced inside
manifest.json.Previously, the project referenced
/icons/assets that did not exist in the repository, which resulted in:✅ Changes Implemented
Added a local
/iconsdirectory with all required PWA assets:icon-72x72.pngicon-192x192.pngicon-192x192-maskable.pngicon-512x512.pngicon-512x512-maskable.pngUpdated
manifest.json:typepurpose: anymaskableicon entriesUpdated
index.html:<meta name="theme-color">for improved mobile/PWA integrationFixed minor PWA-related inconsistencies:
🚀 Critical Requirement Coverage
This directly addresses the critical PWA installability issue by ensuring all manifest icon paths are valid and locally available. The browser can now successfully load required assets for:
The application now behaves as a fully installable Progressive Web App without silent failures caused by missing assets.
🎯 GSSoC Points Target
level:criticalquality:exceptionalgssoc:approved,level:critical,quality:exceptional💎 Quality Checklist (Mandatory for "Exceptional")
📸 Screenshots / Video
Added screenshots showing:
🧪 Testing Done
Ran the project locally using:
Tested in Chrome DevTools:
Confirmed:
Verified responsive behavior and local asset loading across refreshes.