FIFO Ledger Entry Caps#142
Merged
Shruti070107 merged 1 commit intoMay 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Description — Part 2 of 4: FIFO Ledger Entry Caps
part 2 of GSSoC issue Closes #136.
Problem
None of the operational ledger
save*Ledgerfunctions (exceptaddSensorSnapshotwhich capped at 50 snapshot objects in its caller) enforced any limit on the number of entries stored. In an active production environment, this leads to unbounded storage growth, performance degradation, and eventually a browser-enforcedlocalStoragequota crash (swallowing subsequent updates entirely).Fix Applied
save*operations for complete robust enforcement:.slice(-MAX_ENTRIES)on the entries array before formatting to JSON and syncing to real-time networks.Code Change (src/app.js)
function saveTrustLedger(events) { try { - window.localStorage.setItem(TRUST_LEDGER_KEY, JSON.stringify(events)); - ReGenXRealtime?.syncRawKey(TRUST_LEDGER_KEY, events, { eventType: 'KPI_UPDATED', rooms: ['network_room', 'providers_room', 'riders_room', 'plants_room'] }); + const capped = Array.isArray(events) ? events.slice(-200) : []; + window.localStorage.setItem(TRUST_LEDGER_KEY, JSON.stringify(capped)); + ReGenXRealtime?.syncRawKey(TRUST_LEDGER_KEY, capped, { eventType: 'KPI_UPDATED', rooms: ['network_room', 'providers_room', 'riders_room', 'plants_room'] }); } catch { /* ignore */ } }🎯 GSSoC Points Target
level:criticalquality:exceptionalgssoc:approved,level:critical,quality:exceptional💎 Quality Checklist
save*routines🧪 Testing Done
localStorageusing DevTools and validated the JSON size boundaries of the operational keys.