[mac] Show parent folder for Cmd+P recents and disambiguate same-name tabs#294
Merged
Conversation
… tabs Cmd+P recents now show the same tertiary-gray parent folder hint that search results already render — they were getting `relativePath: url.lastPathComponent`, which made the row's `displayPath` empty. Recents inside an open vault use `VaultIndex.relativePath`; orphan recents fall back to the immediate parent folder name. Tabs gain a `parent/filename` qualifier (parent in tertiary) only when two open tabs share a filename, via a new `WorkspaceManager.tabLabel` helper that mirrors the collision pattern from `wikiLinkTarget`. Fixes #254
Deploying clearly with
|
| Latest commit: |
462fddd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://afa05252.clearly-cjz.pages.dev |
| Branch Preview URL: | https://cmdp-paths-and-tabs.clearly-cjz.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
relativePath: url.lastPathComponent, which made the row'sdisplayPathempty. In-vault recents now useVaultIndex.relativePath; orphan recents fall back to the immediate parent folder name.parent/filenamequalifier (parent in tertiary) only when two open tabs share a filename, via a newWorkspaceManager.tabLabel(for:)helper modeled on the existingwikiLinkTargetcollision pattern.Fixes #254
Test plan
SKILL Notes).SKILL.mdfiles in different folders: tabs renderNotes/SKILL.mdandProjects/SKILL.mdwith the folder portion in tertiary.SKILL.md.