[mac] Add View → Hide Toolbar (⌥⌘T) for focused writing#292
Merged
Conversation
Toggles `window.toolbar?.isVisible` from a custom NSMenuItem injected into
the View menu. State persists in UserDefaults("toolbarHidden"). When the
toolbar is hidden, traffic lights also fade out and reappear on hover near
the top of the window. Scrubs the AppKit-auto-injected "Hide Toolbar" /
"Customize Toolbar…" items so they don't race with the custom action.
Fixes #287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.toolbar?.isVisiblefromClearlyAppDelegate, persisted inUserDefaults("toolbarHidden").NSEventmouseMoved monitor when the cursor enters the top ~50pt of the window — a true focus-mode chrome hide.Fixes #287
Test plan