[mac] Fix preview outline navigation (#260)#275
Merged
Conversation
…hlight bleed Outline clicks in preview mode were scrolling to the wrong heading (or landing nowhere) and showing a yellow find-indicator pulse over the hidden editor that bled through SwiftUI's opacity-0 layer. - scrollToHeading now does 3-tier fallback (exact line:col match on data-sourcepos, then line-only, then closest-by-line text-content match with anchor-link stripped) so the outline always finds a sensible target even when the regex parser and cmark-gfm disagree about which lines are headings. - Skip scrollToRange (which fires showFindIndicator) when the editor is not the visible pane — eliminates the yellow rectangle bleed-through. - Add a brief in-preview flash on the matched heading text, parallel to the edit-mode find indicator: bright yellow mark wrapping just the heading text (excluding the hover anchor link), fades out over ~1.3s. Fixes #260
Deploying clearly with
|
| Latest commit: |
9260638
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://778b5d04.clearly-cjz.pages.dev |
| Branch Preview URL: | https://outline-anchor-mismatch.clearly-cjz.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showFindIndicatorwhen the editor isn't the visible pane — fixes the yellow rectangle that was bleeding through SwiftUI's opacity-0 layer onto the preview.Fixes #260
Test plan
data-sourceposcolumn doesn't match Swift's column 1 (e.g. 1–3 leading spaces) — tier 2 line-only match takes over.