Introduce configuration file support#888
Open
vinistock wants to merge 3 commits into
Open
Conversation
6dbe73e to
b77dd62
Compare
Co-authored-by: Alex Rocha <alexcrocha@users.noreply.github.com>
Co-authored-by: Alex Rocha <alexcrocha@users.noreply.github.com>
Co-authored-by: Alex Rocha <alexcrocha@users.noreply.github.com>
b77dd62 to
d60d74e
Compare
Member
|
The implementation looks good but I'm not sure about the format we use for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While Rubydex is a framework that can be used to build all sorts of tools, in most cases we want consistency in the base analysis.
For example, imagine you have an LSP and a linter based on Rubydex, but because they each configure the framework differently, you get different results in the editor vs in the CLI. That would be a pretty poor experience.
I believe we can provide an easy way to ensure consistency while still maintaining flexibility so that the odd case can load custom configuration files for a random tool.
Implementation
I recommend reviewing per commit:
load_configin the Ruby API.rubydexdefault configuration for this repo itselfI went with a simple text/ini format to avoid extra dependencies. It's super simple to parse and entirely based on new lines and commas.