Extract Rubydex native adapter helpers#886
Open
st0012 wants to merge 2 commits into
Open
Conversation
2d9bb4b to
84a78f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
NULLhandling, Ruby string creation, andfree_c_stringownership pattern.Solutions
rdxi_graph_from_handleto centralize handle and graph typed-data unpacking while preserving the existing Ruby graph object ownership.rdxi_owned_c_string_to_rubyfor Rust-owned strings and use it only at existingfree_c_stringcallsites.