Make definition nesting usable for constant resolution#877
Draft
soutaro wants to merge 4 commits into
Draft
Conversation
Assisted-By: devx/7c3d70e1-327c-4158-8ab5-ffccba197089
Assisted-By: devx/7c3d70e1-327c-4158-8ab5-ffccba197089
Assisted-By: devx/7c3d70e1-327c-4158-8ab5-ffccba197089
Assisted-By: devx/7c3d70e1-327c-4158-8ab5-ffccba197089
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Graph#resolve_constantuse recursive resolution so rooted nesting frames resolve correctly.source_namefor class, module, and constant definitions so callers can preserve source-level constant paths like::Bar.Tests
cargo test -p rubydex recursive_constant_resolutioncargo test -p rubydex-sysshadowenv exec -- bundle exec rake compileshadowenv exec -- bundle exec ruby -Itest test/graph_test.rbshadowenv exec -- bundle exec ruby -Itest test/definition_test.rb -n /source_name/