Add memory benchmark through jemalloc allocation trace#875
Open
vinistock wants to merge 1 commit into
Open
Conversation
st0012
reviewed
Jun 24, 2026
a679766 to
c647a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not exactly #864, but a decent step towards it if we decide to move forward
I've been suspecting that our memory measurements using RSS are not super precise. Based on my understanding, max RSS represents the peak memory used by the process. Since we spawn multiple threads during indexing, I assumed that the peak would probably occur during that phase, but that's not what we're interested in. Instead, we want to know the amount of memory that the final graph consumes.
This PR adds a memory benchmark. The way it works is:
[[bench]]means that the code is always built in release mode, but can use development-only dependencies. The executable builds the graph and compares the memory being used before and after dropping itI also added a convenience script that runs the benchmark for a given path and optionally accepts a
--compareargument. When using--compare, it just runs the benchmark againstmainfirst to allow comparing the results.In all workspaces I tried, the max RSS approach overestimates the amount of memory being used: