-
Notifications
You must be signed in to change notification settings - Fork 13
Query the in-memory graph with Cypher #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paracycle
wants to merge
8
commits into
main
Choose a base branch
from
uk_add_cypher_query_engine
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8e3400c
Add read-only Cypher query engine over the in-memory graph
paracycle e3c1975
Add --query and --schema flags to rubydex_cli
paracycle 13f37ec
Expose Cypher via Rubydex::Graph and the rdx command CLI
paracycle af7ea68
Extract the Cypher engine into the standalone cypher-parser crate
paracycle bc2a231
Parse Cypher queries into a reusable Query object before building the…
paracycle 1fc8598
Use cypher.rs instead of cypher/mod.rs module file
paracycle 15a5462
Document the CONTAINS vs OWNS distinction on RelType
paracycle 7e08a7b
Distinguish Document path from name and parse URIs robustly
paracycle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than quick one off switches, like
--version, I would assume everything in this executable always depends on a populated graph (like interactive mode or query).What do you think of keeping the one off switches as early returns at the top, then we populate the graph and the different commands simply perform different operations on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, that is correct, except for the
schemasubcommand handling, which returns a rendering of the schema (with documentation) without needing to index anything.I could turn
schemasubcommand into a--schemaflag for thequerysubcommand, if you want, and that would then become special handling for that subcommand, and we can do what you are suggesting.Let me know what you prefer.