Add more tests for superclass resolution behaviour#860
Conversation
This behaviour is implied by other tests, but I would like to single it out specifically.
| ); | ||
| } | ||
|
|
||
| // Contrast with this case, which Ruby allows:: |
There was a problem hiding this comment.
I think this is already encoded in the other tests, so I would remove it from this one.
There was a problem hiding this comment.
Which one? I don't see it
There was a problem hiding this comment.
Is this not the same as C1 in superclass_is_load_order_independent? Also, I would split each thing into their own test rather than checking multiple things in each example.
There was a problem hiding this comment.
-
It's exercising the same code, but it's making a different claim about it. I tried to explain it on the docs of this test:
Unlike the
superclass_is_load_order_independent()test which covers contradictions across files,
contradictions within the same file are deterministically an issue. -
What I'm trying to emphasize here is the contrast that one order is deterministically always an issue, whereas the other order is deterministically always okay. And that it's not automatically an issue to not have the superclass clause repeated the same, but that the order is what matters (within the scope of a single file)
There was a problem hiding this comment.
Okay, that's fine. What do you think about splitting everything into separate examples though?
2 participants
Documents existing behaviour as-is.
Adds some pending tests that will need to be fixed in the future for: