Ensure descendants are cleaned up when removing a top level declaration#785
Open
vinistock wants to merge 1 commit into
Open
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
04-18-ensure_descendants_are_cleaned_up_when_removing_a_top_level_declaration
branch
from
9eda9e2 to
bcc2d8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't always cleaning up descendants properly if certain declaration scenarios are modified.
This PR ensures that we clean up descendants for modified declarations and adds a test example that breaks before the patch.