Centralize tool result error handling in format with error_line helper

[LasmarKhalifa]

Part of #919

Foundation PR for the tool result formatter implementations.

[LasmarKhalifa]

• [PROTOTYPE] [WIP] Regex for parsing taskoutput results #984
• [PROTOTYPE] [WIP] REXML for parsing taskoutput tool results #983
• add taskoutput tool result formatter backed by nokogiri #960
• add task tool result formatter #963
• add agent tool result formatter #962
• add taskcreate tool result formatter #959
• add taskupdate tool result formatter #958
• add todowrite tool result formatter #957
• add skill tool result formatter #956
• add edit tool result formatter #955
• add write tool result formatter #954
• add grep tool result formatter #953
• add glob tool result formatter #952
• add read tool result formatter #951
• add bash tool result formatter #949
• Centralize tool result error handling in format with error_line helper #948 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[juniper-shopify]

Nice foundation PR! The error-handling centralization is clean — pulling the error path into an early-return at the top of format means every downstream formatter only needs to think about the success case. Makes the rest of your stack cleaner.

Two small things to address:

1. The error_line doc comment could use a couple of examples (see inline comment).
2. A test for error_line when content is nil would round out the edge-case coverage.

And lets switch to the xml parser we had talked about

[LasmarKhalifa]

Merge activity

• Jun 25, 6:03 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jun 25, 6:04 PM UTC: Graphite rebased this pull request as part of a merge.
• Jun 25, 6:06 PM UTC: Graphite rebased this pull request as part of a merge.
• Jun 25, 6:06 PM UTC: @LasmarKhalifa merged this pull request with Graphite.