Update docs for sameSite option#2019
Open
camelmasa wants to merge 1 commit into
Open
Conversation
cartogram
approved these changes
Aug 22, 2022
rennyG
approved these changes
Aug 23, 2022
rennyG
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Does this change affect tutorials or other docs?
Contributor
Author
|
I checked all docs in this repo. I don't think there is any other. |
Contributor
Author
|
I ignored that in CHANGELOG.md. |
Contributor
Author
|
Ah, I need to change |
7372ab6 to
61a6c27
Compare
Contributor
Author
|
DONE! camelmasa@camelmasanoMacBook-Pro hydrogen % ag sameSite
docs/framework/hydrogen-config.md
173: sameSite: 'Strict',
docs/components/framework/cookie.md
19: sameSite: 'Strict',
39:| sameSite | <code>"Lax" | "Strict" | "None"</code> | Declares that the cookie should be restricted to a first-party or [same-site](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite) context. |
docs/components/framework/filesessionstorage.md
23: sameSite: 'Strict',
docs/components/framework/memorysessionstorage.md
22: sameSite: 'Strict',
docs/components/framework/cookiesessionstorage.md
22: sameSite: 'Strict',
examples/multipass/hydrogen.config.ts
13: sameSite: 'Strict',
packages/hydrogen/CHANGELOG.md
1123: sameSite: 'strict',
1165: - sameSite: 'strict',
1285: + sameSite: 'strict',
packages/hydrogen/src/foundation/Cookie/Cookie.ts
16: sameSite?: 'Lax' | 'Strict' | 'None';
packages/create-hydrogen-app/CHANGELOG.md
244: + sameSite: 'strict',
templates/demo-store/hydrogen.config.ts
20: sameSite: 'Strict', |
Contributor
Author
|
@rennyG Do we need to update other files? |
Contributor
I did a search on this key/value in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just updated docs for
sameSiteoption.Ref: https://github.com/Shopify/hydrogen/blob/ee370be6d74b330db78d95b85f1733c8ca3eb2d7/packages/hydrogen/src/foundation/Cookie/Cookie.ts#L16
Before submitting the PR, please make sure you do the following:
fixes #123)