Add session storage to DevTools#1920
Draft
cartogram wants to merge 2 commits into
Draft
Conversation
frehner
reviewed
Jul 28, 2022
| import {Table} from './Table.js'; | ||
|
|
||
| interface Props { | ||
| session: any; |
Contributor
There was a problem hiding this comment.
If we're not able to get a concrete type for this, then this should be unknown. We're trying to move away from any as it's not typesafe.
Makes me realize I should go update the eslint / typescript configs for this 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a session display to the DevTools for debugging the project's chosen session type.
Additional context
Before submitting the PR, please make sure you do the following:
fixes #123)yarn changeset addif this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning