Skip to content

Move Minimum Node Version to 18#1840

Open
vlucas wants to merge 4 commits into
v1.x-2022-07from
vl/nodeversion
Open

Move Minimum Node Version to 18#1840
vlucas wants to merge 4 commits into
v1.x-2022-07from
vl/nodeversion

Conversation

@vlucas

@vlucas vlucas commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

Description

Ensure that the minimum Node version is 18. This ensures that globals like fetch, formData, etc. are always available.

Node 18 - New globally available browser-compatible APIs

Additional context

Also updated starter templates

@github-actions github-actions Bot had a problem deploying to preview July 13, 2022 21:40 Failure
@vlucas

vlucas commented Jul 13, 2022

Copy link
Copy Markdown
Contributor Author

Looks like we need to poke the Oxygen team to upgrade Node:

error demo-store@0.0.0: The engine “node” is incompatible with this module. Expected version “>=18". Got “16.16.0”

@frehner

frehner commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

I think Stackblitz may also only be on 16?

@vlucas

vlucas commented Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

@frehner That's a good point on StackBlitz. We need to ensure they support Node 18 before we can push this out and then drop all our polyfills.

@vlucas

vlucas commented Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

I left a comment on the StackBlitz issue for custom Node versions. We will see what they say or do.

@vlucas vlucas changed the title Minimum Node Version is 18 Move Minimum Node Version to 18 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants