merge queue: checking #2443 on main (c7232a4) - #2448
Closed
mergify[bot] wants to merge 3 commits into
Closed
mergify[bot] wants to merge 3 commits into
mergify[bot] wants to merge 3 commits into
Conversation
Replace the inline host double loop computing the sink-sink CFL in evolve_once() with a new ComputeCFLSinkSink<Tvec> node, modelled on ComputeCFLDust1Fluid. The node reads G, C_force, eta_phi and the synchronized sink_pos/sink_mass/sink_acc_ext edges and writes the rank CFL into an IDataEdge<Tscal>. The !pos.empty() guard and the cfl_detail entry stay in the solver, so the logged CFL table is unchanged. Assisted-by: Claude Code
Write the node's LaTeX description from its edge tex symbols, following the replace_all pattern used by the other SPH nodes. Also add the missing `template` keyword on the synchronized_data get_edge_ptr calls, which are dependent names inside the Solver template. Assisted-by: Claude Code
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thanks @mergify[bot] for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
Contributor
Workflow reportworkflow report corresponding to commit 5d37c8a Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportDoxygen diff with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#2443 is queued for merge on branch main (c7232a4).
This pull request has been created by Mergify to check the mergeability of #2443.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
main queuefor merge:check-success = allRequired conditions to stay in the queue:
approved-reviews-by >= 1check-success = all_lightcheck-success = pre-commit.ci - pr