[SPH] migrate ghost handling in sph prestep to solvergraph by tdavidcl · Pull Request #2447 · Shamrock-code/Shamrock

tdavidcl · 2026-09-23T20:14:42Z

Here comes a big one ....

coderabbitai · 2026-09-23T20:14:49Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-23T20:32:09Z

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label full-ci to run the full test suite (default is light CI; full CI also runs on Mergify merge-queue branches).
5 - Add label profile-build to run the compile-time build profile job even in light CI.
6 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

Second step of migrating the SPH ghost interface build to solvergraph. The interface finder is split into one self-contained node per boundary condition: FindGhostInterfacesFree, FindGhostInterfacesPeriodic and FindGhostInterfacesShearingPeriodic. The body of each node is the matching branch of the former BasicSPHGhostHandler::find_interfaces, moved and adapted to read its inputs from edges (the code duplication between the three branches is kept as is here). Inputs are the sim box, the serial patch tree, the per patch interaction radius and its max over the patch tree, and the local patch boxes; the shearing periodic node additionally takes the time as an input edge and holds its shear base/direction/speed as parameters. A PatchtreeFieldEdge solvergraph edge is added to carry a field defined on the serial patch tree nodes. BasicSPHGhostHandler::find_interfaces becomes a temporary wrapper building the edges from the scheduler and dispatching on the ghost config. To keep the shear offset bitwise identical, the handler ShearingPeriodic config now stores the time instead of shear_speed * time, the product being computed by the node (NFC). Assisted-by: Claude Code

…nodes The three ghost interface finder nodes (Free, Periodic, ShearingPeriodic) carried the same patch tree traversal, copied from the former find_interfaces branches. It is now shared in a single file local helper, the nodes only differing by the set of domain images (offset, offset speed, periodicity index) they loop over. The traversal itself is unchanged: senders are processed with an omp parallel for, interfaces are inserted under omp critical, and the interface of a patch with itself is only skipped for the unshifted image (NFC). Assisted-by: Claude Code

Third step of migrating the SPH ghost interface build to solvergraph. The max reduction of the patch interaction radius over the serial patch tree now lives in a self-contained ComputePatchTreeMaxField node writing a PatchtreeFieldEdge. To make it scheduler free, SerialPatchTree gains a make_patch_tree_field overload that only takes the per patch values (the scheduler was only used by an unused local); the old overload forwards to it, so other callers (GSPH) are unchanged. SPHUtilities::build_interf_cache now wires ComputePatchTreeMaxField, the per boundary condition interface finder (still dispatched by the handler find_interfaces wrapper) and BuildGhostInterfaceIdTable with temporary edges. BasicSPHGhostHandler::make_interface_cache and the gen_id_table_interfaces wrapper are removed as they have no caller left (NFC). Assisted-by: Claude Code

…olver Last step of migrating the SPH ghost interface build (gen_ghost_handler / build_interf_cache) to self-contained solvergraph nodes; integrating them into the main solver graph is left for a later change. Solver::build_ghost_cache(time) now wires ComputePatchTreeMaxField, the interface finder node matching the boundary condition of the solver config (FindGhostInterfacesFree / Periodic / ShearingPeriodic, the latter fed with the time through an edge) and BuildGhostInterfaceIdTable with temporary edges built around the callsite. The boundary condition dispatch moves from gen_ghost_handler to the choice of the finder node. As a result BasicSPHGhostHandler no longer needs a boundary condition config: BasicSPHGhostHandlerConfig, the ghost_config member and constructor argument, find_interfaces and GeneratorMap are removed, as is SPHUtilities::build_interf_cache. gen_ghost_handler only builds the handler still used downstream for the ghost communications (NFC). Assisted-by: Claude Code

github-actions · 2026-09-24T18:44:51Z

Workflow report

workflow report corresponding to commit 643d80a
Commiter email is timothee.david--cleris@ens-lyon.fr

Light CI is enabled (the default for pull requests). This will only run the basic tests and not the full tests.
Full CI runs if the full-ci label is set, or automatically on Mergify merge-queue branches (mergify/merge-queue/*).
The merge gate job "on PR / all" is skipped in this case. Queue entry uses "on PR / all_light"; full CI runs in the merge queue.

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report


27537 warnings generated.
Suppressed 27538 warnings (27537 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:38:20: warning: invalid case style for type template parameter 'vec' [readability-identifier-naming]
   38 |     template<class vec>
      |                    ^~~
      |                    Vec
   39 |     class BasicSPHGhostHandler {
   40 | 
   41 |         PatchScheduler &sched;
   42 | 
   43 |         public:
   44 |         using flt                = shambase::VecComponent<vec>;
      |                                                           ~~~
      |                                                           Vec
   45 |         static constexpr u32 dim = shambase::VectorProperties<vec>::dimension;
      |                                                               ~~~
      |                                                               Vec
   46 |         using per_index          = sycl::vec<i32, dim>;
   47 | 
   48 |         struct InterfaceBuildInfos {
   49 |             vec offset;
      |             ~~~
      |             Vec
   50 |             vec offset_speed;
      |             ~~~
      |             Vec
   51 |             per_index periodicity_index;
   52 |             shammath::CoordRange<vec> cut_volume;
      |                                  ~~~
      |                                  Vec
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:38:20: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:44:59: note: FIX-IT applied suggested code changes
   44 |         using flt                = shambase::VecComponent<vec>;
      |                                                           ^
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:45:63: note: FIX-IT applied suggested code changes
   45 |         static constexpr u32 dim = shambase::VectorProperties<vec>::dimension;
      |                                                               ^
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:49:13: note: FIX-IT applied suggested code changes
   49 |             vec offset;
      |             ^
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:50:13: note: FIX-IT applied suggested code changes
   50 |             vec offset_speed;
      |             ^
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:52:34: note: FIX-IT applied suggested code changes
   52 |             shammath::CoordRange<vec> cut_volume;
      |                                  ^
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:247:43: note: FIX-IT applied suggested code changes
  247 |                     sender_pdat.get_field<vec>(0).append_subset_to(
      |                                           ^
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:248:53: note: FIX-IT applied suggested code changes
  248 |                         buf_idx, cnt, ret.get_field<vec>(0));
      |                                                     ^
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:252:35: note: FIX-IT applied suggested code changes
  252 |                     ret.get_field<vec>(0).apply_offset(binfo.offset);
      |                                   ^
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:423:36: note: FIX-IT applied suggested code changes
  423 |                     PatchDataField<vec> &pos   = pdat.get_field<vec>(0);
      |                                    ^
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:423:65: note: FIX-IT applied suggested code changes
  423 |                     PatchDataField<vec> &pos   = pdat.get_field<vec>(0);
      |                                                                 ^
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:428:35: note: FIX-IT applied suggested code changes
  428 |                     ret.get_field<vec>(0).insert(pos);
      |                                   ^

27545 warnings generated.
clang-tidy applied 12 of 12 suggested fixes.
Suppressed 27545 warnings (27543 in non-user code, 1 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:69:30: warning: invalid case style for constexpr variable 'Rkern' [readability-identifier-naming]
   69 |         static constexpr flt Rkern = SPHKernel::Rkern;
      |                              ^~~~~
      |                              rkern
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:69:30: note: FIX-IT applied suggested code changes

27655 warnings generated.
clang-tidy applied 1 of 1 suggested fixes.
Suppressed 27655 warnings (27649 in non-user code, 5 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

27907 warnings generated.
Suppressed 27908 warnings (27906 in non-user code, 1 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

27544 warnings generated.
Suppressed 27545 warnings (27544 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shammodels/sph/src/BasicSPHGhosts.cpp:28:16: warning: invalid case style for type template parameter 'vec' [readability-identifier-naming]
   28 | template<class vec>
      |                ^~~
      |                Vec
   29 | void BasicSPHGhostHandler<vec>::gen_debug_patch_ghost(
      |                           ~~~
      |                           Vec
/__w/Shamrock/Shamrock/src/shammodels/sph/src/BasicSPHGhosts.cpp:28:16: note: FIX-IT applied suggested code changes
/__w/Shamrock/Shamrock/src/shammodels/sph/src/BasicSPHGhosts.cpp:29:27: note: FIX-IT applied suggested code changes
   29 | void BasicSPHGhostHandler<vec>::gen_debug_patch_ghost(
      |                           ^

27551 warnings generated.
clang-tidy applied 2 of 2 suggested fixes.
Suppressed 27551 warnings (27550 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

27541 warnings generated.
Suppressed 27542 warnings (27541 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

27541 warnings generated.
Suppressed 27542 warnings (27538 in non-user code, 3 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

27552 warnings generated.
Suppressed 27553 warnings (27552 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

28287 warnings generated.
Suppressed 28288 warnings (28271 in non-user code, 16 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

Suggested changes

Detailed changes :

diff --git a/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp b/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp
index 2434fdfe..dc1812f7 100644
--- a/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp
+++ b/src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp
@@ -35,21 +35,21 @@
 
 namespace shammodels::sph {
 
-    template<class vec>
+    template<class Vec>
     class BasicSPHGhostHandler {
 
         PatchScheduler &sched;
 
         public:
-        using flt                = shambase::VecComponent<vec>;
-        static constexpr u32 dim = shambase::VectorProperties<vec>::dimension;
+        using flt                = shambase::VecComponent<Vec>;
+        static constexpr u32 dim = shambase::VectorProperties<Vec>::dimension;
         using per_index          = sycl::vec<i32, dim>;
 
         struct InterfaceBuildInfos {
-            vec offset;
-            vec offset_speed;
+            Vec offset;
+            Vec offset_speed;
             per_index periodicity_index;
-            shammath::CoordRange<vec> cut_volume;
+            shammath::CoordRange<Vec> cut_volume;
             flt volume_ratio;
         };
 
@@ -244,12 +244,12 @@ namespace shammodels::sph {
 
                     shamrock::patch::PatchDataLayer ret(xyzh_ghost_layout);
 
-                    sender_pdat.get_field<vec>(0).append_subset_to(
-                        buf_idx, cnt, ret.get_field<vec>(0));
+                    sender_pdat.get_field<Vec>(0).append_subset_to(
+                        buf_idx, cnt, ret.get_field<Vec>(0));
                     sender_pdat.get_field<flt>(ihpart).append_subset_to(
                         buf_idx, cnt, ret.get_field<flt>(1));
 
-                    ret.get_field<vec>(0).apply_offset(binfo.offset);
+                    ret.get_field<Vec>(0).apply_offset(binfo.offset);
 
                     return ret;
                 });
@@ -420,12 +420,12 @@ namespace shammodels::sph {
                 std::forward<shambase::DistributedDataShared<shamrock::patch::PatchDataLayer>>(
                     positioninterfs),
                 [=, this](const shamrock::patch::Patch p, shamrock::patch::PatchDataLayer &pdat) {
-                    PatchDataField<vec> &pos   = pdat.get_field<vec>(0);
+                    PatchDataField<Vec> &pos   = pdat.get_field<Vec>(0);
                     PatchDataField<flt> &hpart = pdat.get_field<flt>(ihpart);
 
                     shamrock::patch::PatchDataLayer ret(xyzh_ghost_layout);
 
-                    ret.get_field<vec>(0).insert(pos);
+                    ret.get_field<Vec>(0).insert(pos);
                     ret.get_field<flt>(1).insert(hpart);
                     ret.check_field_obj_cnt_match();
 
diff --git a/src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp b/src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp
index e08e4356..d8091256 100644
--- a/src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp
+++ b/src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp
@@ -66,7 +66,7 @@ namespace shammodels::sph {
         public:
         using flt = shambase::VecComponent<vec>;
 
-        static constexpr flt Rkern = SPHKernel::Rkern;
+        static constexpr flt rkern = SPHKernel::Rkern;
 
         using GhostHndl = BasicSPHGhostHandler<vec>;
 
diff --git a/src/shammodels/sph/src/BasicSPHGhosts.cpp b/src/shammodels/sph/src/BasicSPHGhosts.cpp
index 4d516936..3197cf48 100644
--- a/src/shammodels/sph/src/BasicSPHGhosts.cpp
+++ b/src/shammodels/sph/src/BasicSPHGhosts.cpp
@@ -25,8 +25,8 @@
 
 using namespace shammodels::sph;
 
-template<class vec>
-void BasicSPHGhostHandler<vec>::gen_debug_patch_ghost(
+template<class Vec>
+void BasicSPHGhostHandler<Vec>::gen_debug_patch_ghost(
     shambase::DistributedDataShared<InterfaceIdTable> &interf_info) {
     StackEntry stack_loc{};

# Doxygen diff with `main` Removed warnings : 77 New warnings : 70 Warnings count : 8189 → 8182 (-0.1%)

Detailed changes :

+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:118: warning: Member modify_interface_native(shambase::DistributedDataShared< InterfaceIdTable > &builder, shambase::DistributedDataShared< T > &mod, std::function< void(u64, u64, InterfaceBuildInfos, sham::DeviceBuffer< u32 > &, u32, T &)> fct) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:120: warning: Member gen_debug_patch_ghost(shambase::DistributedDataShared< InterfaceIdTable > &interf_info) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:122: warning: Member CacheMap (typedef) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:162: warning: The following parameters of shammodels::sph::BasicSPHGhostHandler::build_interface_native_stagged(shambase::DistributedDataShared< InterfaceIdTable > &builder, std::function< T(u64, u64, InterfaceBuildInfos, sycl::buffer< u32 > &, u32)> gen_1, std::function< void(u64, u64, InterfaceBuildInfos, sycl::buffer< u32 > &, u32, T &)> modif) are not documented:
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:162: warning: argument 'fct' of command @param is not found in the argument list of shammodels::sph::BasicSPHGhostHandler< vec >::build_interface_native_stagged(shambase::DistributedDataShared< InterfaceIdTable > &builder, std::function< T(u64, u64, InterfaceBuildInfos, sycl::buffer< u32 > &, u32)> gen_1, std::function< void(u64, u64, InterfaceBuildInfos, sycl::buffer< u32 > &, u32, T &)> modif)
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:183: warning: Member modify_interface_native(shambase::DistributedDataShared< InterfaceIdTable > &builder, shambase::DistributedDataShared< T > &mod, std::function< void(u64, u64, InterfaceBuildInfos, sham::DeviceBuffer< u32 > &, u32, T &)> fct) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:227: warning: The following parameters of shammodels::sph::BasicSPHGhostHandler::build_interface_native_stagged(shambase::DistributedDataShared< InterfaceIdTable > &builder, std::function< T(u64, u64, InterfaceBuildInfos, sycl::buffer< u32 > &, u32)> gen_1, std::function< void(u64, u64, InterfaceBuildInfos, sycl::buffer< u32 > &, u32, T &)> modif) are not documented:
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:227: warning: argument 'fct' of command @param is not found in the argument list of shammodels::sph::BasicSPHGhostHandler< vec >::build_interface_native_stagged(shambase::DistributedDataShared< InterfaceIdTable > &builder, std::function< T(u64, u64, InterfaceBuildInfos, sycl::buffer< u32 > &, u32)> gen_1, std::function< void(u64, u64, InterfaceBuildInfos, sycl::buffer< u32 > &, u32, T &)> modif)
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:229: warning: Member build_position_interf_field(shambase::DistributedDataShared< InterfaceIdTable > &builder) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:258: warning: Member communicate_pdat(const std::shared_ptr< shamrock::patch::PatchDataLayerLayout > &pdl_ptr, shambase::DistributedDataShared< shamrock::patch::PatchDataLayer > &&interf, std::shared_ptr< shamrock::solvergraph::ExchangeGhostLayer > exchange_gz_node, bool show_debug_infos) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:294: warning: Member build_position_interf_field(shambase::DistributedDataShared< InterfaceIdTable > &builder) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:323: warning: Member communicate_pdat(const std::shared_ptr< shamrock::patch::PatchDataLayerLayout > &pdl_ptr, shambase::DistributedDataShared< shamrock::patch::PatchDataLayer > &&interf, std::shared_ptr< shamrock::solvergraph::ExchangeGhostLayer > exchange_gz_node, bool show_debug_infos) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:326: warning: Member communicate_pdatfield(shambase::DistributedDataShared< PatchDataField< T > > &&interf, u32 nvar, std::shared_ptr< shamrock::solvergraph::ExchangeGhostField< T > > exchange_gz_node) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:377: warning: Member build_communicate_positions(shambase::DistributedDataShared< InterfaceIdTable > &builder, std::shared_ptr< shamrock::solvergraph::ExchangeGhostLayer > &exchange_gz_positions, bool show_debug_infos) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:387: warning: Member merge_native(shambase::DistributedDataShared< T > &&interfs, std::function< Tmerged(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> init, std::function< void(Tmerged &, T &)> appender) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:391: warning: Member communicate_pdatfield(shambase::DistributedDataShared< PatchDataField< T > > &&interf, u32 nvar, std::shared_ptr< shamrock::solvergraph::ExchangeGhostField< T > > exchange_gz_node) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:39: warning: Compound shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:40: warning: Compound shammodels::sph::BasicSPHGhostHandlerConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:413: warning: Member merge_position_buf(shambase::DistributedDataShared< shamrock::patch::PatchDataLayer > &&positioninterfs) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:42: warning: Member Tscal (typedef) of struct shammodels::sph::BasicSPHGhostHandlerConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:442: warning: Member build_comm_merge_positions(shambase::DistributedDataShared< InterfaceIdTable > &builder, std::shared_ptr< shamrock::solvergraph::ExchangeGhostLayer > &exchange_gz_positions, bool show_debug_infos) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:442: warning: Member build_communicate_positions(shambase::DistributedDataShared< InterfaceIdTable > &builder, std::shared_ptr< shamrock::solvergraph::ExchangeGhostLayer > &exchange_gz_positions, bool show_debug_infos) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:44: warning: Member flt (typedef) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:452: warning: Member merge_native(shambase::DistributedDataShared< T > &&interfs, std::function< Tmerged(const shamrock::patch::Patch, shamrock::patch::PatchDataLayer &pdat)> init, std::function< void(Tmerged &, T &)> appender) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:45: warning: Member dim (variable) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:46: warning: Compound shammodels::sph::BasicSPHGhostHandlerConfig::ShearingPeriodic is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:46: warning: Member per_index (typedef) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:478: warning: Member merge_position_buf(shambase::DistributedDataShared< shamrock::patch::PatchDataLayer > &&positioninterfs) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:47: warning: Member shear_base (variable) of struct shammodels::sph::BasicSPHGhostHandlerConfig::ShearingPeriodic is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:48: warning: Compound shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:48: warning: Member shear_dir (variable) of struct shammodels::sph::BasicSPHGhostHandlerConfig::ShearingPeriodic is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:49: warning: Member offset (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:49: warning: Member shear_value (variable) of struct shammodels::sph::BasicSPHGhostHandlerConfig::ShearingPeriodic is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:507: warning: Member build_comm_merge_positions(shambase::DistributedDataShared< InterfaceIdTable > &builder, std::shared_ptr< shamrock::solvergraph::ExchangeGhostLayer > &exchange_gz_positions, bool show_debug_infos) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:50: warning: Member offset_speed (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:50: warning: Member shear_speed (variable) of struct shammodels::sph::BasicSPHGhostHandlerConfig::ShearingPeriodic is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:51: warning: Member periodicity_index (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:52: warning: Member cut_volume (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:53: warning: Member Variant (typedef) of struct shammodels::sph::BasicSPHGhostHandlerConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:53: warning: Member volume_ratio (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:56: warning: Compound shammodels::sph::BasicSPHGhostHandler::InterfaceIdTable is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:57: warning: Compound shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:57: warning: Member build_infos (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceIdTable is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:58: warning: Member ids_interf (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceIdTable is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:59: warning: Member part_cnt_ratio (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceIdTable is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:62: warning: Member xyzh_ghost_layout (variable) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:64: warning: Member patch_rank_owner (variable) of class shammodels::sph::BasicSPHGhostHandler is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:66: warning: Member BasicSPHGhostHandler(PatchScheduler &sched, std::shared_ptr< shamrock::solvergraph::RankGetter > patch_rank_owner, std::shared_ptr< shamrock::patch::PatchDataLayerLayout > &xyzh_ghost_layout) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:66: warning: Member flt (typedef) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:67: warning: Member dim (variable) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:68: warning: Member per_index (typedef) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:70: warning: Compound shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:71: warning: Member offset (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:72: warning: Member offset_speed (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:73: warning: Member gen_debug_patch_ghost(shambase::DistributedDataShared< InterfaceIdTable > &interf_info) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:73: warning: Member periodicity_index (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:74: warning: Member cut_volume (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
+ src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:75: warning: Member CacheMap (typedef) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:75: warning: Member volume_ratio (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceBuildInfos is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:78: warning: Compound shammodels::sph::BasicSPHGhostHandler::InterfaceIdTable is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:79: warning: Member build_infos (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceIdTable is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:80: warning: Member ids_interf (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceIdTable is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:81: warning: Member part_cnt_ratio (variable) of struct shammodels::sph::BasicSPHGhostHandler::InterfaceIdTable is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:84: warning: Member GeneratorMap (typedef) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:86: warning: Member xyzh_ghost_layout (variable) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:88: warning: Member patch_rank_owner (variable) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/BasicSPHGhosts.hpp:90: warning: Member BasicSPHGhostHandler(PatchScheduler &sched, Config ghost_config, std::shared_ptr< shamrock::solvergraph::RankGetter > patch_rank_owner, std::shared_ptr< shamrock::patch::PatchDataLayerLayout > &xyzh_ghost_layout) (function) of class shammodels::sph::BasicSPHGhostHandler is not documented.
- src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:105: warning: Member iterate_smoothing_length_cache(sham::DeviceBuffer< vec > &merged_r, sham::DeviceBuffer< flt > &hnew, sham::DeviceBuffer< flt > &hold, sham::DeviceBuffer< flt > &eps_h, sycl::range< 1 > update_range, shamrock::tree::ObjectCache &neigh_cache, flt gpart_mass, flt h_evol_max, flt h_evol_iter_max) (function) of class shammodels::sph::SPHUtilities is not documented.
+ src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:119: warning: Member compute_omega(sham::DeviceBuffer< vec > &merged_r, sham::DeviceBuffer< flt > &h_part, sham::DeviceBuffer< flt > &omega_h, sycl::range< 1 > part_range, shamrock::tree::ObjectCache &neigh_cache, flt gpart_mass) (function) of class shammodels::sph::SPHUtilities is not documented.
- src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:121: warning: Member iterate_smoothing_length_tree(sycl::buffer< vec > &merged_r, sycl::buffer< flt > &hnew, sycl::buffer< flt > &hold, sycl::buffer< flt > &eps_h, sycl::range< 1 > update_range, RadixTree< u_morton, vec > &tree, flt gpart_mass, flt h_evol_max, flt h_evol_iter_max) (function) of class shammodels::sph::SPHUtilities is not documented.
- src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:147: warning: Member compute_omega(sham::DeviceBuffer< vec > &merged_r, sham::DeviceBuffer< flt > &h_part, sham::DeviceBuffer< flt > &omega_h, sycl::range< 1 > part_range, shamrock::tree::ObjectCache &neigh_cache, flt gpart_mass) (function) of class shammodels::sph::SPHUtilities is not documented.
- src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:72: warning: Member InterfBuildCache (typedef) of class shammodels::sph::SPHUtilities is not documented.
+ src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:73: warning: Member sched (variable) of class shammodels::sph::SPHUtilities is not documented.
- src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:74: warning: Member sched (variable) of class shammodels::sph::SPHUtilities is not documented.
+ src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:75: warning: Member SPHUtilities(PatchScheduler &sched) (function) of class shammodels::sph::SPHUtilities is not documented.
- src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:76: warning: Member SPHUtilities(PatchScheduler &sched) (function) of class shammodels::sph::SPHUtilities is not documented.
+ src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:77: warning: Member iterate_smoothing_length_cache(sham::DeviceBuffer< vec > &merged_r, sham::DeviceBuffer< flt > &hnew, sham::DeviceBuffer< flt > &hold, sham::DeviceBuffer< flt > &eps_h, sycl::range< 1 > update_range, shamrock::tree::ObjectCache &neigh_cache, flt gpart_mass, flt h_evol_max, flt h_evol_iter_max) (function) of class shammodels::sph::SPHUtilities is not documented.
- src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:78: warning: Member build_interf_cache(GhostHndl &interf_handle, SerialPatchTree< vec > &sptree, flt h_evol_max) (function) of class shammodels::sph::SPHUtilities is not documented.
+ src/shammodels/sph/include/shammodels/sph/SPHUtilities.hpp:93: warning: Member iterate_smoothing_length_tree(sycl::buffer< vec > &merged_r, sycl::buffer< flt > &hnew, sycl::buffer< flt > &hold, sycl::buffer< flt > &eps_h, sycl::range< 1 > update_range, RadixTree< u_morton, vec > &tree, flt gpart_mass, flt h_evol_max, flt h_evol_iter_max) (function) of class shammodels::sph::SPHUtilities is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:246: warning: Member gen_ghost_handler() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:246: warning: Member gen_ghost_handler(Tscal time_val) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:250: warning: Member reset_ghost_handler() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:265: warning: Member RTree (typedef) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:290: warning: Member reset_ghost_handler() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:301: warning: Member RTree (typedef) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:319: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:327: warning: Member set_debug_dump(bool _do_debug_dump, std::string _debug_dump_filename) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:331: warning: Member print_timestep_logs() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:349: warning: Member evolve_until(Tscal target_time, i32 niter_max, f64 max_walltime=-1) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:355: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:363: warning: Member set_debug_dump(bool _do_debug_dump, std::string _debug_dump_filename) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:367: warning: Member print_timestep_logs() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:385: warning: Member evolve_until(Tscal target_time, i32 niter_max, f64 max_walltime=-1) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputePatchTreeMaxField.hpp:25: warning: Member NODE_EDGES(X_RO, X_RW) (macro definition) of file ComputePatchTreeMaxField.hpp is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/FindGhostInterfaces.hpp:115: warning: Member NODE_EDGES(X_RO, X_RW) (macro definition) of file FindGhostInterfaces.hpp is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/FindGhostInterfaces.hpp:136: warning: Member FindGhostInterfacesShearingPeriodic(i32_3 shear_base, i32_3 shear_dir, Tscal shear_speed) (function) of class shammodels::sph::modules::FindGhostInterfacesShearingPeriodic is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/FindGhostInterfaces.hpp:42: warning: Member FIND_GHOST_INTERFACES_EDGES_OUT(X_RW) (macro definition) of file FindGhostInterfaces.hpp is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/FindGhostInterfaces.hpp:62: warning: Member Tscal (typedef) of struct shammodels::sph::modules::FindGhostInterfacesTypes is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/FindGhostInterfaces.hpp:63: warning: Member InterfaceBuildInfos (typedef) of struct shammodels::sph::modules::FindGhostInterfacesTypes is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/FindGhostInterfaces.hpp:66: warning: Member NODE_EDGES(X_RO, X_RW) (macro definition) of file FindGhostInterfaces.hpp is not documented.
- src/shammodels/sph/src/BasicSPHGhosts.cpp:167: warning: Compound ShiftInfo is not documented.
- src/shammodels/sph/src/BasicSPHGhosts.cpp:173: warning: Member ShearPeriodicInfo (typedef) of file BasicSPHGhosts.cpp is not documented.
- src/shammodels/sph/src/BasicSPHGhosts.cpp:177: warning: Member compute_shift_infos(i32_3 ioff, ShearPeriodicInfo< T > shear, sycl::vec< T, 3 > bsize) (function) of file BasicSPHGhosts.cpp is not documented.
- src/shammodels/sph/src/BasicSPHGhosts.cpp:199: warning: Member for_each_patch_shift(ShearPeriodicInfo< T > shearinfo, sycl::vec< T, 3 > bsize, std::function< void(i32_3, ShiftInfo< T >)> funct) (function) of file BasicSPHGhosts.cpp is not documented.
- src/shammodels/sph/src/Solver.cpp:1297: warning: Compound shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:1298: warning: Member Tscal (typedef) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:1300: warning: Member nobj (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:1301: warning: Member gpart_mass (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:1303: warning: Member buf_xyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:1304: warning: Compound shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:1304: warning: Member buf_hpart (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:1305: warning: Member Tscal (typedef) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:1305: warning: Member buf_vxyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:1307: warning: Member nobj (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:1308: warning: Member gpart_mass (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:1309: warning: Member fill_blocks(PhantomDumpBlock &block, Debug_ph_dump< Tvec > &info) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/src/Solver.cpp:1310: warning: Member buf_xyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:1311: warning: Member buf_hpart (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:1312: warning: Member buf_vxyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:1316: warning: Member fill_blocks(PhantomDumpBlock &block, Debug_ph_dump< Tvec > &info) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/src/Solver.cpp:1346: warning: Member make_interface_debug_phantom_dump(Debug_ph_dump< Tvec > info) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/src/Solver.cpp:1353: warning: Member make_interface_debug_phantom_dump(Debug_ph_dump< Tvec > info) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/src/Solver.cpp:2237: warning: Member map_field_refs(PatchScheduler &sched, u32 field_idx, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
- src/shammodels/sph/src/Solver.cpp:2252: warning: Member map_field_refs_ext(PatchScheduler &sched, shambase::DistributedData< shamrock::patch::PatchDataLayer > &mpdats, u32 field_idx, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
- src/shammodels/sph/src/Solver.cpp:2271: warning: Member map_field_refs_ext(PatchScheduler &sched, shamrock::ComputeField< T > &field_data, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
+ src/shammodels/sph/src/Solver.cpp:2356: warning: Member map_field_refs(PatchScheduler &sched, u32 field_idx, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
+ src/shammodels/sph/src/Solver.cpp:2371: warning: Member map_field_refs_ext(PatchScheduler &sched, shambase::DistributedData< shamrock::patch::PatchDataLayer > &mpdats, u32 field_idx, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
+ src/shammodels/sph/src/Solver.cpp:2390: warning: Member map_field_refs_ext(PatchScheduler &sched, shamrock::ComputeField< T > &field_data, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
- src/shamrock/include/shamrock/scheduler/SerialPatchTree.hpp:223: warning: Member dump_dat() (function) of class SerialPatchTree is not documented.
+ src/shamrock/include/shamrock/scheduler/SerialPatchTree.hpp:233: warning: Member dump_dat() (function) of class SerialPatchTree is not documented.
- src/shamrock/include/shamrock/scheduler/SerialPatchTree.hpp:246: warning: Member compute_patch_owner(sham::DeviceScheduler_ptr dev_sched, sham::DeviceBuffer< fp_prec_vec > &position_buffer, u32 len) (function) of class SerialPatchTree is not documented.
+ src/shamrock/include/shamrock/scheduler/SerialPatchTree.hpp:256: warning: Member compute_patch_owner(sham::DeviceScheduler_ptr dev_sched, sham::DeviceBuffer< fp_prec_vec > &position_buffer, u32 len) (function) of class SerialPatchTree is not documented.
+ src/shamrock/include/shamrock/solvergraph/PatchtreeFieldEdge.hpp:35: warning: Member IEdgeNamed(std::string name, std::string texsymbol) (function) of class shamrock::solvergraph::PatchtreeFieldEdge is not documented.

tdavidcl force-pushed the claude/dreamy-brown-thszgi branch 2 times, most recently from 82eb35b to fe9680f Compare September 24, 2026 14:56

Timothée David--Cléris added 4 commits September 24, 2026 16:56

tdavidcl force-pushed the claude/dreamy-brown-thszgi branch from fe9680f to 643d80a Compare September 24, 2026 17:10

tdavidcl mentioned this pull request Sep 28, 2026

[SPH] move find_interfaces into per boundary condition solvergraph nodes #2466

Open

Navigation Menu

Repository navigation

[SPH] migrate ghost handling in sph prestep to solvergraph - #2447

[SPH] migrate ghost handling in sph prestep to solvergraph#2447
tdavidcl wants to merge 4 commits into
Shamrock-code:mainfrom
tdavidcl:claude/dreamy-brown-thszgi

tdavidcl commented Sep 23, 2026

Uh oh!

coderabbitai Bot commented Sep 23, 2026

Draft PR not reviewed

Uh oh!

github-actions Bot commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

tdavidcl commented Sep 23, 2026

Uh oh!

coderabbitai Bot commented Sep 23, 2026

Draft PR not reviewed

Uh oh!

github-actions Bot commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026

Workflow report

Pre-commit check report

Clang-tidy diff report

Suggested changes

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant