Skip to content

[Doc] Add Apple M4 Max result to godunov homogeneous benchmark - #2429

Merged
mergify[bot] merged 2 commits into
Shamrock-code:mainfrom
tdavidcl:claude/jolly-euler-o4xj5k
Sep 22, 2026
Merged

mergify[bot] merged 2 commits into
Shamrock-code:mainfrom
tdavidcl:claude/jolly-euler-o4xj5k

Conversation

@tdavidcl

Copy link
Copy Markdown
Member

Assisted-by: Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label full-ci to run the full test suite (default is light CI; full CI also runs on Mergify merge-queue branches).
5 - Add label profile-build to run the compile-time build profile job even in light CI.
6 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a007e106-2bf3-4348-b287-afcfc57c1918

📥 Commits

Reviewing files that changed from the base of the PR and between 89301fb and 86815c5.

📒 Files selected for processing (1)
  • examples/benchmarks/godunov_homogeneous_bench_result.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ec727403-8596-47c5-ac2c-08a455c3f713

📥 Commits

Reviewing files that changed from the base of the PR and between 2afc3e0 and 89301fb.

📒 Files selected for processing (1)
  • examples/benchmarks/godunov_homogeneous_bench_result.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Benchmark results

Layer / File(s) Summary
Append Apple M4 Max benchmark record
examples/benchmarks/godunov_homogeneous_bench_result.json
Adds benchmark data for an Apple M4 Max CPU using the OpenMP backend and AdaptiveCpp 25.10.0. The record includes timing, compiler, device, MPI, and microbenchmark metadata.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: akos299

Merge Risk: ⚪ Minimal · up to 89301

This change only adds a documented Apple M4 Max benchmark record and does not alter executable code, so it is mergeable.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description only states "Assisted-by: Claude Code" and does not describe the Apple M4 Max benchmark result. Add a brief description that states the PR adds an Apple M4 Max OpenMP result to the Godunov homogeneous benchmark.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the addition of an Apple M4 Max result to the Godunov homogeneous benchmark. It matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 2
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch claude/jolly-euler-o4xj5k
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Resolve conflict in godunov_homogeneous_bench_result.json by keeping
both the newly added Apple M4 Max entry and upstream's newly added
Intel Data Center GPU Max 1550 entry.

Assisted-by: Claude Code
@github-actions

Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit 86815c5
Commiter email is timothee.davidcleris@proton.me

Light CI is enabled (the default for pull requests). This will only run the basic tests and not the full tests.
Full CI runs if the full-ci label is set, or automatically on Mergify merge-queue branches (mergify/merge-queue/*).
The merge gate job "on PR / all" is skipped in this case. Queue entry uses "on PR / all_light"; full CI runs in the merge queue.

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 8186 → 8186 (0.0%)

Detailed changes :

@tdavidcl

Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify

mergify Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 hours 58 seconds in the queue, including 1 hour 48 minutes 8 seconds running CI.

Required conditions to merge
  • check-success = all

@mergify mergify Bot added the queued label Sep 22, 2026
@mergify
mergify Bot merged commit b57eea5 into Shamrock-code:main Sep 22, 2026
38 checks passed
@mergify mergify Bot removed the queued label Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants