Conversation
Contributor
|
Thanks @tdavidcl for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new update_fields API allowing Python callbacks to get and set patch fields via a PatchDataSetup proxy class, replacing the previous lambda-based field setters. Feedback suggests vectorizing the loop in the Python example using NumPy operations to improve performance, and refactoring duplicated registration logic for f64 and f64_3 fields in PatchDataToPy.hpp into a single template helper function.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+294
to
+338
| inline void register_field_io_f64(PatchDataSetup &setup, PatchDataField<f64> &field) { | ||
| std::string name = field.get_name(); | ||
| setup.register_getter(name, [&field]() -> py::array_t<f64> { | ||
| return VecToNumpy<f64>::convert(field.get_buf().copy_to_stdvec()); | ||
| }); | ||
| setup.register_setter(name, [&field](py::array_t<f64> arr) { | ||
| auto vec = NumpyToVec<f64>::convert(arr); | ||
| if (vec.size() != field.get_val_cnt()) { | ||
| throw shambase::make_except_with_loc<std::invalid_argument>(shambase::format( | ||
| "field \"{}\": array size {} does not match field val_cnt {}", | ||
| field.get_name(), | ||
| vec.size(), | ||
| field.get_val_cnt())); | ||
| } | ||
| field.get_buf().copy_from_stdvec(vec); | ||
| }); | ||
| } | ||
|
|
||
| inline void register_field_io_f64_3(PatchDataSetup &setup, PatchDataField<f64_3> &field) { | ||
| std::string name = field.get_name(); | ||
| setup.register_getter(name, [&field]() -> py::array_t<f64> { | ||
| return VecToNumpy<f64_3>::convert(field.get_buf().copy_to_stdvec()); | ||
| }); | ||
| setup.register_setter(name, [&field](py::array_t<f64> arr) { | ||
| auto vec = NumpyToVec<f64_3>::convert(arr); | ||
| if (vec.size() != field.get_val_cnt()) { | ||
| throw shambase::make_except_with_loc<std::invalid_argument>(shambase::format( | ||
| "field \"{}\": array size {} does not match field val_cnt {}", | ||
| field.get_name(), | ||
| vec.size(), | ||
| field.get_val_cnt())); | ||
| } | ||
| field.get_buf().copy_from_stdvec(vec); | ||
| }); | ||
| } | ||
|
|
||
| inline void register_f64_layout_fields( | ||
| PatchDataSetup &setup, shamrock::patch::PatchDataLayer &pdat) { | ||
| pdat.for_each_field<f64>([&](auto &field) { | ||
| register_field_io_f64(setup, field); | ||
| }); | ||
| pdat.for_each_field<f64_3>([&](auto &field) { | ||
| register_field_io_f64_3(setup, field); | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
The logic for registering f64 and f64_3 fields is identical except for the template type. Refactoring this into a single template helper function reduces code duplication and improves maintainability.
template<typename T>
inline void register_field_io(PatchDataSetup &setup, PatchDataField<T> &field) {
std::string name = field.get_name();
setup.register_getter(name, [&field]() -> py::array_t<f64> {
return VecToNumpy<T>::convert(field.get_buf().copy_to_stdvec());
});
setup.register_setter(name, [&field](py::array_t<f64> arr) {
auto vec = NumpyToVec<T>::convert(arr);
if (vec.size() != field.get_val_cnt()) {
throw shambase::make_except_with_loc<std::invalid_argument>(shambase::format(
"field \"{}\": array size {} does not match field val_cnt {}",
field.get_name(),
vec.size(),
field.get_val_cnt()));
}
field.get_buf().copy_from_stdvec(vec);
});
}
inline void register_f64_layout_fields(
PatchDataSetup &setup, shamrock::patch::PatchDataLayer &pdat) {
pdat.for_each_field<f64>([&](auto &field) {
register_field_io<f64>(setup, field);
});
pdat.for_each_field<f64_3>([&](auto &field) {
register_field_io<f64_3>(setup, field);
});
}References
- Refactor duplicated logic into a helper function or lambda to improve readability and maintainability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Workflow reportworkflow report corresponding to commit 51d90f7 Light CI is enabled (the default for pull requests). This will only run the basic tests and not the full tests. Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportSuggested changesDetailed changes :diff --git a/src/shampylib/include/shampylib/PatchDataToPy.hpp b/src/shampylib/include/shampylib/PatchDataToPy.hpp
index 08e4cac9..f8b2c85c 100644
--- a/src/shampylib/include/shampylib/PatchDataToPy.hpp
+++ b/src/shampylib/include/shampylib/PatchDataToPy.hpp
@@ -24,6 +24,8 @@
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
+#include <utility>
+
namespace shamrock {
template<class T>
class VecToNumpy;
@@ -258,7 +260,7 @@ namespace shamrock {
template<>
class NumpyToVec<f64> {
public:
- static std::vector<f64> convert(py::array_t<f64> arr) {
+ static std::vector<f64> convert(const py::array_t<f64>& arr) {
if (arr.ndim() != 1) {
throw shambase::make_except_with_loc<std::invalid_argument>(
shambase::format("expected 1D array for f64 field, got ndim={}", arr.ndim()));
@@ -276,7 +278,7 @@ namespace shamrock {
template<>
class NumpyToVec<f64_3> {
public:
- static std::vector<f64_3> convert(py::array_t<f64> arr) {
+ static std::vector<f64_3> convert(const py::array_t<f64>& arr) {
if (arr.ndim() != 2 || arr.shape(1) != 3) {
throw shambase::make_except_with_loc<std::invalid_argument>(
"expected (N, 3) array for f64_3 field");
@@ -297,7 +299,7 @@ namespace shamrock {
return VecToNumpy<f64>::convert(field.get_buf().copy_to_stdvec());
});
setup.register_setter(name, [&field](py::array_t<f64> arr) {
- auto vec = NumpyToVec<f64>::convert(arr);
+ auto vec = NumpyToVec<f64>::convert(std::move(arr));
if (vec.size() != field.get_val_cnt()) {
throw shambase::make_except_with_loc<std::invalid_argument>(shambase::format(
"field \"{}\": array size {} does not match field val_cnt {}",
@@ -315,7 +317,7 @@ namespace shamrock {
return VecToNumpy<f64_3>::convert(field.get_buf().copy_to_stdvec());
});
setup.register_setter(name, [&field](py::array_t<f64> arr) {
- auto vec = NumpyToVec<f64_3>::convert(arr);
+ auto vec = NumpyToVec<f64_3>::convert(std::move(arr));
if (vec.size() != field.get_val_cnt()) {
throw shambase::make_except_with_loc<std::invalid_argument>(shambase::format(
"field \"{}\": array size {} does not match field val_cnt {}",Detailed changes :- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:107: warning: Member get_cell_coords(std::pair< TgridVec, TgridVec > block_coords, u32 lid) (function) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:116: warning: Member evolve_once_time_expl(f64 t_curr, f64 dt_input) (function) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:120: warning: Member timestep() (function) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:122: warning: Member evolve_once() (function) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:127: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:135: warning: Member dump(std::string fname) (function) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:158: warning: Member get_cell_coords(std::pair< TgridVec, TgridVec > block_coords, u32 lid) (function) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:167: warning: Member evolve_once_time_expl(f64 t_curr, f64 dt_input) (function) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:171: warning: Member timestep() (function) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:173: warning: Member evolve_once() (function) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:178: warning: Member evolve_until(Tscal target_time, i32 niter_max) (function) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:186: warning: Member dump(std::string fname) (function) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:34: warning: Compound shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:36: warning: Member Tscal (typedef) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:37: warning: Member dim (variable) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:38: warning: Compound shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:38: warning: Member ctx (variable) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:40: warning: Member Solver (typedef) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:40: warning: Member Tscal (typedef) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:41: warning: Member dim (variable) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:41: warning: Member solver (variable) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:42: warning: Member ctx (variable) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:43: warning: Member Model(ShamrockCtx &ctx) (function) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:44: warning: Member Solver (typedef) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:45: warning: Member solver (variable) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:47: warning: Member Model(ShamrockCtx &ctx) (function) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:60: warning: Member make_base_grid(TgridVec bmin, TgridVec cell_size, u32_3 cell_count) (function) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:62: warning: Member dump_vtk(std::string filename) (function) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:64: warning: Member make_base_grid(TgridVec bmin, TgridVec cell_size, u32_3 cell_count) (function) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/include/shammodels/ramses/Model.hpp:65: warning: Member set_field_value_lambda(std::string field_name, const std::function< T(Tvec, Tvec)> pos_to_val, const i32 offset) (function) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:66: warning: Member dump_vtk(std::string filename) (function) of class shammodels::basegodunov::Model is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/Model.hpp:69: warning: Member set_field_value_lambda(std::string field_name, const std::function< T(Tvec, Tvec)> pos_to_val, const i32 offset) (function) of class shammodels::basegodunov::Model is not documented.
- src/shammodels/ramses/src/pyRamsesModel.cpp:33: warning: Member add_instance(py::module &m, std::string name_config, std::string name_model) (function) of namespace shammodels::basegodunov is not documented.
+ src/shammodels/ramses/src/pyRamsesModel.cpp:34: warning: Member add_instance(py::module &m, std::string name_config, std::string name_model) (function) of namespace shammodels::basegodunov is not documented.
- src/shammodels/ramses/src/pyRamsesModel.cpp:403: warning: Member ON_PYTHON_INIT (variable) of file pyRamsesModel.cpp is not documented.
- src/shammodels/ramses/src/pyRamsesModel.cpp:406: warning: Member mramses (variable) of file pyRamsesModel.cpp is not documented.
- src/shammodels/ramses/src/pyRamsesModel.cpp:408: warning: Member add_instance< f64_3, i64_3 >(mramses, base_name+"_f64_3_i64_3_SolverConfig", base_name+"_f64_3_i64_3_Model") (function) of file pyRamsesModel.cpp is not documented.
- src/shammodels/ramses/src/pyRamsesModel.cpp:408: warning: Member base_name (variable) of file pyRamsesModel.cpp is not documented.
+ src/shammodels/ramses/src/pyRamsesModel.cpp:409: warning: Member ON_PYTHON_INIT (variable) of file pyRamsesModel.cpp is not documented.
+ src/shammodels/ramses/src/pyRamsesModel.cpp:412: warning: Member mramses (variable) of file pyRamsesModel.cpp is not documented.
- src/shammodels/ramses/src/pyRamsesModel.cpp:414: warning: Member VariantAMRGodunovBind (typedef) of file pyRamsesModel.cpp is not documented.
+ src/shammodels/ramses/src/pyRamsesModel.cpp:414: warning: Member add_instance< f64_3, i64_3 >(mramses, base_name+"_f64_3_i64_3_SolverConfig", base_name+"_f64_3_i64_3_Model") (function) of file pyRamsesModel.cpp is not documented.
+ src/shammodels/ramses/src/pyRamsesModel.cpp:414: warning: Member base_name (variable) of file pyRamsesModel.cpp is not documented.
- src/shammodels/ramses/src/pyRamsesModel.cpp:416: warning: Member def("get_Model_Ramses", [](ShamrockCtx &ctx, std::string vector_type, std::string grid_repr) -> VariantAMRGodunovBind { VariantAMRGodunovBind ret;if(vector_type=="f64_3" &&grid_repr=="i64_3") { ret=std::make_unique< Model< f64_3, i64_3 > >(ctx);} else { throw shambase::make_except_with_loc< std::invalid_argument >("unknown combination of representation and grid_repr");} return ret;}, py::kw_only(), py::arg("context"), py::arg("vector_type"), py::arg("grid_repr")) (function) of file pyRamsesModel.cpp is not documented.
+ src/shammodels/ramses/src/pyRamsesModel.cpp:420: warning: Member VariantAMRGodunovBind (typedef) of file pyRamsesModel.cpp is not documented.
+ src/shammodels/ramses/src/pyRamsesModel.cpp:422: warning: Member def("get_Model_Ramses", [](ShamrockCtx &ctx, std::string vector_type, std::string grid_repr) -> VariantAMRGodunovBind { VariantAMRGodunovBind ret;if(vector_type=="f64_3" &&grid_repr=="i64_3") { ret=std::make_unique< Model< f64_3, i64_3 > >(ctx);} else { throw shambase::make_except_with_loc< std::invalid_argument >("unknown combination of representation and grid_repr");} return ret;}, py::kw_only(), py::arg("context"), py::arg("vector_type"), py::arg("grid_repr")) (function) of file pyRamsesModel.cpp is not documented.
+ src/shampylib/include/shampylib/PatchDataSetup.hpp:42: warning: Member register_getter(std::string name, std::function< py::array_t< f64 >()> fn) (function) of class shamrock::PatchDataSetup is not documented.
+ src/shampylib/include/shampylib/PatchDataSetup.hpp:46: warning: Member register_setter(std::string name, std::function< void(py::array_t< f64 >)> fn) (function) of class shamrock::PatchDataSetup is not documented.
+ src/shampylib/include/shampylib/PatchDataSetup.hpp:50: warning: Member get(const std::string &name) const (function) of class shamrock::PatchDataSetup is not documented.
+ src/shampylib/include/shampylib/PatchDataSetup.hpp:59: warning: Member set(const std::string &name, py::array_t< f64 > value) const (function) of class shamrock::PatchDataSetup is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:104: warning: Compound shamrock::VecToNumpy< sycl::vec< T, 8 > > is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:106: warning: Member convert(std::vector< sycl::vec< T, 8 > > vec) (function) of class shamrock::VecToNumpy< sycl::vec< T, 8 > > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:107: warning: Compound shamrock::VecToNumpy< sycl::vec< T, 8 > > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:109: warning: Member convert(std::vector< sycl::vec< T, 8 > > vec) (function) of class shamrock::VecToNumpy< sycl::vec< T, 8 > > is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:128: warning: Compound shamrock::VecToNumpy< sycl::vec< T, 16 > > is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:130: warning: Member convert(std::vector< sycl::vec< T, 16 > > vec) (function) of class shamrock::VecToNumpy< sycl::vec< T, 16 > > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:131: warning: Compound shamrock::VecToNumpy< sycl::vec< T, 16 > > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:133: warning: Member convert(std::vector< sycl::vec< T, 16 > > vec) (function) of class shamrock::VecToNumpy< sycl::vec< T, 16 > > is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:161: warning: Member append_to_map(std::string key, std::vector< std::reference_wrapper< shamrock::patch::PatchDataLayer > > ref_lst, py::dict &dic_out) (function) of namespace shamrock is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:164: warning: Member append_to_map(std::string key, std::vector< std::reference_wrapper< shamrock::patch::PatchDataLayer > > ref_lst, py::dict &dic_out) (function) of namespace shamrock is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:207: warning: Member append_to_map(std::string key, std::vector< std::unique_ptr< shamrock::patch::PatchDataLayer > > &lst, py::dict &dic_out) (function) of namespace shamrock is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:210: warning: Member append_to_map(std::string key, std::vector< std::unique_ptr< shamrock::patch::PatchDataLayer > > &lst, py::dict &dic_out) (function) of namespace shamrock is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:222: warning: Member pdat_to_dic(shamrock::patch::PatchDataLayer &pdat) (function) of namespace shamrock is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:225: warning: Member pdat_to_dic(shamrock::patch::PatchDataLayer &pdat) (function) of namespace shamrock is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:259: warning: Compound shamrock::NumpyToVec< f64 > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:261: warning: Member convert(py::array_t< f64 > arr) (function) of class shamrock::NumpyToVec< f64 > is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:26: warning: Compound shamrock::VecToNumpy is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:277: warning: Compound shamrock::NumpyToVec< f64_3 > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:279: warning: Member convert(py::array_t< f64 > arr) (function) of class shamrock::NumpyToVec< f64_3 > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:294: warning: Member register_field_io_f64(PatchDataSetup &setup, PatchDataField< f64 > &field) (function) of namespace shamrock is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:312: warning: Member register_field_io_f64_3(PatchDataSetup &setup, PatchDataField< f64_3 > &field) (function) of namespace shamrock is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:31: warning: Member convert(std::vector< T > vec) (function) of class shamrock::VecToNumpy is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:32: warning: Compound shamrock::VecToNumpy is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:330: warning: Member register_f64_layout_fields(PatchDataSetup &setup, shamrock::patch::PatchDataLayer &pdat) (function) of namespace shamrock is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:34: warning: Member convert(std::vector< T > vec) (function) of class shamrock::VecToNumpy is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:47: warning: Compound shamrock::VecToNumpy< sycl::vec< T, 2 > > is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:49: warning: Member convert(std::vector< sycl::vec< T, 2 > > vec) (function) of class shamrock::VecToNumpy< sycl::vec< T, 2 > > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:50: warning: Compound shamrock::VecToNumpy< sycl::vec< T, 2 > > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:52: warning: Member convert(std::vector< sycl::vec< T, 2 > > vec) (function) of class shamrock::VecToNumpy< sycl::vec< T, 2 > > is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:65: warning: Compound shamrock::VecToNumpy< sycl::vec< T, 3 > > is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:67: warning: Member convert(std::vector< sycl::vec< T, 3 > > vec) (function) of class shamrock::VecToNumpy< sycl::vec< T, 3 > > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:68: warning: Compound shamrock::VecToNumpy< sycl::vec< T, 3 > > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:70: warning: Member convert(std::vector< sycl::vec< T, 3 > > vec) (function) of class shamrock::VecToNumpy< sycl::vec< T, 3 > > is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:84: warning: Compound shamrock::VecToNumpy< sycl::vec< T, 4 > > is not documented.
- src/shampylib/include/shampylib/PatchDataToPy.hpp:86: warning: Member convert(std::vector< sycl::vec< T, 4 > > vec) (function) of class shamrock::VecToNumpy< sycl::vec< T, 4 > > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:87: warning: Compound shamrock::VecToNumpy< sycl::vec< T, 4 > > is not documented.
+ src/shampylib/include/shampylib/PatchDataToPy.hpp:89: warning: Member convert(std::vector< sycl::vec< T, 4 > > vec) (function) of class shamrock::VecToNumpy< sycl::vec< T, 4 > > is not documented.
+ src/shampylib/src/pyPatchDataSetup.cpp:20: warning: Member ON_PYTHON_INIT (variable) of file pyPatchDataSetup.cpp is not documented.
+ src/shampylib/src/pyPatchDataSetup.cpp:23: warning: Member py::class_< shamrock::PatchDataSetup >(m, "PatchDataSetup") .def("get" (function) of file pyPatchDataSetup.cpp is not documented.
+ src/shampylib/src/pyPatchDataSetup.cpp:23: warning: Member shamlog_debug_ln("[Py]", "registering shamrock.PatchDataSetup") (function) of file pyPatchDataSetup.cpp is not documented.
+ src/shampylib/src/pyPatchDataSetup.cpp:26: warning: documented symbol 'py::arg' was not declared or defined.
+ src/shampylib/src/pyPatchDataSetup.cpp:27: warning: documented symbol 'py::arg' was not declared or defined. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.