fix: multiplatform sbom and vulnscan#160
Merged
Merged
Conversation
JonZeolla
commented
Aug 18, 2023
JonZeolla
commented
Aug 18, 2023
JonZeolla
commented
Aug 18, 2023
JonZeolla
commented
Aug 18, 2023
JonZeolla
commented
Aug 18, 2023
JonZeolla
commented
Aug 19, 2023
JonZeolla
commented
Aug 19, 2023
JonZeolla
commented
Aug 19, 2023
3 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Comments
This fixes multiplatform SBOM generation and vuln scanning. Little tricky and some workarounds due to:
Manual Testing
To test this I was running
task -v clean; for platform in all linux/arm64 linux/amd64; do PLATFORM=$platform task -v build; PLATFORM=$platform task -v sbom vulnscan; doneand you should see:build,sbom, orvulnscanrunstarfiles in your local environment for the platform that you aren't on - so that would be the multiplatform build (arm and amd) and the arm (if you are on amd) or the amd (if you are on arm). If you are on arm, the arm build (or amd with amd) should be loaded into your docker daemon; see that withdocker image ls | head -10There may be some other, better and more creative ways to test.
Pull Request Checklist
Thank you for submitting a contribution to the goat!
In order to streamline the review of your contribution we ask that you review and comply with the below requirements: