[ShanaBoo] Registration token subject should match returned user id#6513
Open
genesisrevelationinc-debug wants to merge 11 commits into
Open
[ShanaBoo] Registration token subject should match returned user id#6513genesisrevelationinc-debug wants to merge 11 commits into
genesisrevelationinc-debug wants to merge 11 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR refactors registerUser to reuse a single generated userId for both the returned user object and the access token subject, improving internal consistency.
Changes:
- Generate
userIdonce and reuse it foridand JWTsub - Update token issuance to reference the generated
userId - (Introduced) an extra trailing brace at end of file, causing a syntax error
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export async function refreshToken() { | ||
| return { token: signAccessToken({ sub: "usr_existing", role: "client" }) }; | ||
| } | ||
| } |
Comment on lines
8
to
+10
| email: payload.email, | ||
| role: payload.role, | ||
| token: signAccessToken({ sub: `usr_${Date.now()}`, role: payload.role }) | ||
| token: signAccessToken({ sub: userId, role: payload.role }) |
Comment on lines
+4
to
+10
| const userId = `usr_${Date.now()}`; | ||
| // TODO: persist new user via Prisma | ||
| return { | ||
| id: `usr_${Date.now()}`, | ||
| id: userId, | ||
| email: payload.email, | ||
| role: payload.role, | ||
| token: signAccessToken({ sub: `usr_${Date.now()}`, role: payload.role }) | ||
| token: signAccessToken({ sub: userId, role: payload.role }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShanaBoo Autonomous Fix
This PR was automatically generated by ShanaBoo Earn Engine to claim the $780.00 bounty on this issue.
Source: Github | Task: 4557148612
Closes #2768
Auto-submitted by ShanaBoo CNS — NVIDIA NIM + Microsoft Agent Framework