[ShanaBoo] Search endpoint has no input validation or length limit on query#6506
Open
genesisrevelationinc-debug wants to merge 12 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds request validation for the q query parameter in the search controller, returning a 400 on invalid input before calling the search service.
Changes:
- Added
badRequesterror response for invalid search queries - Introduced
validateSearchQuery()to trim and enforce a maximum query length search()now validates/sanitizesreq.query.qprior to callingglobalSearch()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| // Trim whitespace | ||
| let trimmedQuery = query.trim(); |
Comment on lines
+15
to
+17
| if (trimmedQuery.length > 200) { | ||
| return { isValid: false, error: 'Search query exceeds maximum length of 200 characters' }; | ||
| } |
Comment on lines
+19
to
+25
| // Basic sanitization (removing potentially harmful characters) | ||
| // Here we just return the trimmed query as it's already been length-checked | ||
| // In a more comprehensive solution, you might want to strip special characters or apply other rules | ||
| return { | ||
| isValid: true, | ||
| sanitizedQuery: trimmedQuery | ||
| }; |
Comment on lines
+29
to
+34
| const query = req.query.q ?? ""; | ||
| const validation = validateSearchQuery(query); | ||
|
|
||
| if (!validation.isValid) { | ||
| return badRequest(res, { error: validation.error }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShanaBoo Autonomous Fix
This PR was automatically generated by ShanaBoo Earn Engine to claim the $780.00 bounty on this issue.
Source: Github | Task: 4557389259
Closes #2833
Auto-submitted by ShanaBoo CNS — NVIDIA NIM + Microsoft Agent Framework