[fix] Reject inverted budget ranges in job validation (#2853)#6497
Open
xiaofengzii wants to merge 1 commit into
Open
[fix] Reject inverted budget ranges in job validation (#2853)#6497xiaofengzii wants to merge 1 commit into
xiaofengzii wants to merge 1 commit into
Conversation
- Add refinement to createJobSchema to ensure budgetMax >= budgetMin - Create separate updateJobSchema with budget validation for partial updates - Add comprehensive tests for both schemas - Fixes SecureBananaLabs#2853 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where createJobSchema accepts payloads where �udgetMax is lower than �udgetMin, creating invalid job records.
Changes
Modified �pps/api/src/validators/job.js:
Added �pps/api/src/tests/job.test.js:
Verification
All tests pass:
Related Issues