Ensure message ids are server-owned#5941
Open
rebel117 wants to merge 1 commit into
Open
Conversation
sendMessage() was spreading the caller payload before assigning the generated id, so a client could override it by including their own id field. Moved the id and sentAt assignments after the spread so they always win. - Reorder property spread in messageService.js - Add 2 regression tests: client-controlled id ignored, normal flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5939 (parent bounty: #743)
POST /api/messageswas spreading the caller payload before assigning the generated id, so a client could include anidfield and override the server-generated one.What changed
idandsentAtassignments after the payload spread so server-owned fields always take precedence over anything the caller provides.idis ignored and that the normal message creation flow still works.Testing
No existing behavior is affected — messages without a caller-supplied
idwork exactly as before.