Skip to content

fix(notification): keep server-owned fields#5936

Open
vexnom wants to merge 1 commit into
SecureBananaLabs:mainfrom
vexnom:fix-notification-server-fields-5935
Open

fix(notification): keep server-owned fields#5936
vexnom wants to merge 1 commit into
SecureBananaLabs:mainfrom
vexnom:fix-notification-server-fields-5935

Conversation

@vexnom

@vexnom vexnom commented Jun 8, 2026

Copy link
Copy Markdown

Closes #5935

/claim #5935

Refs parent bounty #743.

Summary

  • keep notification ids server-owned by assigning the generated id after caller payload fields
  • keep new notifications unread by assigning read: false after caller payload fields
  • add regression coverage proving caller-controlled id and read are ignored
  • update the API test script so Node's test runner runs the existing test files

Tests

  • npm test -w apps/api

Payout: Base USDC 0x42430d6ade79041f569dc5e28153052ccef82ea6

github-actions Bot added a commit that referenced this pull request Jun 8, 2026
@vexnom vexnom force-pushed the fix-notification-server-fields-5935 branch 10 times, most recently from 91c3138 to fdee722 Compare June 9, 2026 12:43
@vexnom vexnom force-pushed the fix-notification-server-fields-5935 branch from fdee722 to 6bdecfd Compare June 9, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification creation should keep id and read state server-owned

1 participant