feat: add pratt and recursive descent parser#181
Open
XboxBedrock wants to merge 12 commits into
Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
maybe-yiyi
requested changes
May 30, 2026
maybe-yiyi
left a comment
maybe-yiyi
left a comment
Member
There was a problem hiding this comment.
- Bug: user space sees
Symbol EOX.
To reproduce, use /courses unlocks (15122 or 15112 or any other two courses.
Error message:
Unexpected token: Symbol(EOX). Expected one of: RPAREN
-
Probably unwanted behavior but the call stack is only checked at evaluation time, not parse time
-
why does this go on newline
Collaborator
Author
|
Changes made |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the current parser with an extensible Pratt/Recursive descent parser. The parser itself is modularized into
tokenizer,parser,errors, andgrammarFactory. The specific implementation of the simple operator grammar we use is inbasicOperatorParser.The parser does have recursive descent capabilities by design, but they are not utilized in
basicOperatorParseras the Pratt parser handles all of the operators we need. For future uses, the recursive descent component may come into play.Addresses #151