Conversation
|
just some things, not sure if some are feasible at all
|
|
|
wait how do you unvote |
|
nevermind seems like that's not a thing, i just added an unvote button instead |
maybe-yiyi
left a comment
There was a problem hiding this comment.
besides these things lgtm
didn't test attempting to delete polls without being the author, but the code looks correct.
- perhaps eventually we can whitelist/blacklist multiple roles
- maybe we consider whether it's necessary to enumerate the poll options, since we aren't voting using the enumeration nor does it really matter for poll results?
maybe-yiyi
left a comment
There was a problem hiding this comment.
great, thanks!
perhaps @TenType will want to review in terms of design, but it looks good to me.
TenType
left a comment
There was a problem hiding this comment.
I'll check this as well tonight, thanks yiyoung!
TenType
left a comment
There was a problem hiding this comment.
looks good, some things I think we should change:
- I'd prefer if we don't show who votes for what by default as it clutters the embed. maybe we can have a button "See voters" that replies with an ephemeral message of voters for each choice
- for anonymous polls, the number of people who voted for each choice is missing - can we also add the running count there as well?
- for time-limited polls, let's also show the time remaining via a discord timestamp
- I think it would be better to use components v2 for creating a poll (similar to how we do reaction redirect setup) than to accept the options via arguments, but this is okay to do in a separate PR
|
Wait does this have ranked choice implemented |
Adds
/pollcommand with six subcommands:setup(configure guild polls channel)create(create a poll with up to 10 options, optional multi-select)results(view vote counts)delete(for admins or poll authors to remove polls)close(to manually close the poll before expiry)myvote(check your own vote on an anonymous poll)Closes https://github.com/ScottyLabs/dalmatian/issues/48