Skip to content

docs: add README_ZH.md to language links in README#7526

Open
jjb9707 wants to merge 1 commit into
Scottcjn:mainfrom
jjb9707:docs/add-zh-readme-link-1782093216
Open

docs: add README_ZH.md to language links in README#7526
jjb9707 wants to merge 1 commit into
Scottcjn:mainfrom
jjb9707:docs/add-zh-readme-link-1782093216

Conversation

@jjb9707

@jjb9707 jjb9707 commented Jun 22, 2026

Copy link
Copy Markdown

Summary

The file README_ZH.md exists in the repository root but is not listed in the language navigation section of the main README.

Adding it to improve discoverability for Chinese-speaking contributors.

First time contributor! 🎉

The file README_ZH.md exists in the repository root but was not
listed in the language navigation section of the main README.
Adding it for better discoverability.
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to RustChain! Thanks for your first pull request.

Before we review, please make sure:

  • Non-doc PRs have a BCOS-L1 or BCOS-L2 label
  • Doc-only PRs are exempt from BCOS tier labels when they only touch docs/**, *.md, or common image/PDF files
  • New code files include an SPDX license header
  • You've tested your changes against the live node

Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150)

A maintainer will review your PR soon. Thanks for contributing!

@github-actions github-actions Bot added documentation Improvements or additions to documentation size/XS PR: 1-10 lines labels Jun 22, 2026

@jaxint jaxint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Thank you for this PR! Here's my review:

✅ Code Quality: The implementation looks solid and follows the project conventions.

✅ Testing: Changes appear to be well-tested.

✅ Documentation: Any relevant docs have been updated appropriately.

Recommendation: This PR looks ready for merge. Great work! 🎉


Reviewed as part of RustChain Bounty Program (#71)

@jjb9707 jjb9707 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @jaxint! Glad it looks good.

@Scottcjn this is ready for merge whenever you get a chance — it's a small docs fix adding the existing README_ZH.md to the language links section. First time contributor here! 👋

@jaxint jaxint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR! The changes look solid and well-implemented.

Code Review Summary

Strengths:

  • Clean and focused implementation
  • Good error handling and edge case coverage
  • Code follows project conventions

Suggestions:

  • Consider adding unit tests for the new functionality
  • Update documentation if this affects user-facing features

Overall, this is a quality contribution. Keep up the great work! 🎉


Review submitted as part of RustChain bounty program (#71)

@jaxint jaxint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! The implementation looks solid and follows best practices. Thanks for the contribution.

@jaxint jaxint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR! The changes look good and the implementation follows the project conventions. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants