SLVUU-129: Fix Application Layouts Data Contract#135
Open
pling-scottlogic wants to merge 15 commits into
Open
Conversation
pling-scottlogic
force-pushed
the
SLVUU-129-settings-in-dto
branch
from
cde0416 to
92c70c6
Compare
pling-scottlogic
force-pushed
the
SLVUU-129-settings-in-dto
branch
from
611c021 to
fe2ef9c
Compare
| start: npm run showcase:preview | ||
| wait-on: "http://localhost:4173" | ||
| start: npm run showcase:preview, npm run layout-server | ||
| wait-on: http://localhost:4173, http://localhost:8081/api/swagger-ui/index.html |
Author
There was a problem hiding this comment.
Not sure if the Swagger page is most appropriate for checking the API status. We could use one of our GET endpoints, or implement a separate endpoint just for status checking.
vferraro-scottlogic
left a comment
vferraro-scottlogic
left a comment
There was a problem hiding this comment.
Looks good for most part just a question and a couple of suggestions for possible improvements
vferraro-scottlogic
approved these changes
Jan 11, 2024
- Removes the anti-pattern of async/await (Cypress does not work well with promises)
pling-scottlogic
force-pushed
the
SLVUU-129-settings-in-dto
branch
from
dcc04bc to
49f8545
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the data contract for the
application-layoutsresource on the layout server. Also introduces end-to-end Cypress tests to ensure the data contract holds.Change List
ApplicationLayoutDtowithObjectNodeto allow for arbitrary JSON structureGetApplicationResponseDtowithApplicationJSONapi.utils.tsto abstract API calls for testingApplicationJSONinterfaceTesting
Changes manually tested using the remote implementation from both showcase and sample app.