When an object is already created, and is not replacing, skip all required fields that were not modified.

[Bernie]

This fixes the issue reported in #346

[lafrech]

Thanks. I agree on the cause.

Would it be a better implementation if we did this?

class EmbeddedDocument:
    def required_validate(self):
        self._data.required_validate(partial=self.is_created)

class DataProxy:
    def required_validate(self, partial):
        [...]
        if partial and name not in self.get_modified_fields():
            [...]

This avoids accessing _data.get_modified_fields from upper layers.

No need to even modify each driver.

Or maybe

class EmbeddedDocument:
    def required_validate(self, update=False):
        self._data.required_validate(update=update)

class DataProxy:
    def required_validate(self, update):
        [...]
        if update and name not in self.get_modified_fields():
            [...]

Needs to specify update explicitly in the drivers but might be better.

[Bernie]

I'm not as familiar with the code, so my fix may not have been as optimal. If this can be done without having to change the API for the drivers, then even better.

…

On Thu, Apr 22, 2021 at 5:27 PM Jérôme Lafréchoux ***@***.***> wrote: ***@***.**** commented on this pull request. Thanks. I agree on the cause. Would it be a better implementation if we did this? class EmbeddedDocument: def required_validate(self): self._data.required_validate(partial=self.is_created) class DataProxy: def required_validate(self, partial): [...] if partial and name not in self.get_modified_fields(): [...] This avoids accessing _data.get_modified_fields from upper layers. No need to even modify each driver. Or maybe class EmbeddedDocument: def required_validate(self, update=False): self._data.required_validate(update=update) class DataProxy: def required_validate(self, update): [...] if update and name not in self.get_modified_fields(): [...] Needs to specify update explicitly in the drivers but might be better. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#347 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABQDSGH3K2OLE4EYRH4UUTTKCIFXANCNFSM43CTDT2Q> .