Include VC Redistributable when building the Windows installer#12868
Include VC Redistributable when building the Windows installer#12868Max-7 wants to merge 1 commit into
Conversation
FirelightFlagboy
left a comment
FirelightFlagboy
left a comment
There was a problem hiding this comment.
It's a choice to include the VC lib in the installer, some other installers provide a link to download the VC lib instead 🤷
|
|
||
| !macro customInstall | ||
| !insertmacro mayInstallWinFSP | ||
| !insertmacro installVCRedist |
There was a problem hiding this comment.
issue: This always install VC, it should check if it's not already installed
There was a problem hiding this comment.
Honestly, the check doesn't even work properly with WinFSP, I always get a pop-up, so why bother?
You get a pop-up, you click next, if it needs to be installed it's installed. One option could also be to run it as /quiet instead of /passive, which doesn't even display a pop-up (appart maybe from Windows UAC). I put /passive because it's what we're doing with WinFSP and it seems a little more transparent.
Where do you put the link? In the installer somewhere? I'm afraid the user won't read and skip the installation. In my opinion, it's just better to bundle that in. |
2 participants
Closes #12775
Closes #9341