Skip to content

Add MANIFEST.in to include requirements.txt in sdist#966

Merged
valyo merged 3 commits into
ScilifelabDataCentre:devfrom
mashehu:fix-setup-requirements
Jun 15, 2026
Merged

Add MANIFEST.in to include requirements.txt in sdist#966
valyo merged 3 commits into
ScilifelabDataCentre:devfrom
mashehu:fix-setup-requirements

Conversation

@mashehu

@mashehu mashehu commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Pull Request Template

Before Marking as Ready for Review

  • Add relevant information to the sections below (Summary etc)
  • Rebase or merge the latest dev (or other targeted branch)
  • Update documentation if needed
  • Add an entry to the SPRINTLOG.md if needed
  • Choose an appropriate label. See here for information on the labelling options
  • The code follows the style guidelines
  • Perform a self-review: read the diff as if reviewing someone else's code
  • I have commented the code, particularly in hard-to-understand areas
  • Verify that all checks and tests have passed

Summary

I am trying to add this to bioconda (see bioconda/bioconda-recipes#64333), but it currently fails to build there, because requirements.txt is not in the sdist, but setup.py requires it.

This change makes sure it gets bundled with the rest of the files

Related Issue/Ticket

@mashehu mashehu requested a review from a team as a code owner June 10, 2026 11:31
@mashehu mashehu force-pushed the fix-setup-requirements branch from d501404 to 4eaad38 Compare June 10, 2026 11:32
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.40%. Comparing base (93b2d4b) to head (ce7e6ed).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #966   +/-   ##
=======================================
  Coverage   55.40%   55.40%           
=======================================
  Files          33       33           
  Lines        3061     3061           
=======================================
  Hits         1696     1696           
  Misses       1365     1365           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valyo valyo added the skip-changelog For release template label Jun 15, 2026
@valyo valyo merged commit e4cccd2 into ScilifelabDataCentre:dev Jun 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For release template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants