QA: run_qa v1.6 form + ExplicitImports#31
Merged
ChrisRackauckas merged 1 commit intoJun 25, 2026
Merged
Conversation
Bring LightweightStats.jl onto the SciMLTesting run_tests folder model and move QA onto the run_qa v1.6 form with ExplicitImports enabled. - test/runtests.jl -> `using SciMLTesting; run_tests()` (folder discovery). - test/test_groups.toml declares Core + QA (QA on lts/1, Core on lts/1/pre). - Core group: the top-level test/*.jl are auto-discovered. The inline mean/median/var/... testsets that lived in runtests.jl move to test/core_tests.jl; regression_tests.jl and interface_tests.jl stay as Core files. - QA group: new test/qa/qa.jl = `run_qa(LightweightStats; explicit_imports = true)` with JET loaded, replacing the hand-rolled test/jet_tests.jl and test/explicit_imports_tests.jl. All 6 ExplicitImports checks pass with no ignore-lists; JET report_package is clean; no @test_broken needed. - test/qa/Project.toml: SciMLTesting "1.6", JET, Test, and Aqua kept as a direct dep so Aqua's ambiguities child-process can find it. ExplicitImports is dropped (transitive via SciMLTesting). - Root [targets].test gains SciMLTesting + SafeTestsets (the @safetestset wrapper used by the folder model needs SafeTestsets resolvable by name) and drops ExplicitImports + JET (now in the QA sub-env). PrecompileTools floor stays 1.2 (the `using PrecompileTools: @compile_workload` macro-only import). - CI Tests.yml switches to grouped-tests.yml@v1 so QA runs as its own lane. Verified locally against released SciMLTesting 1.6.0: QA group 18/18 on Julia 1.10 (lts) and 1.11 (1); Core group 69 + 33 + 322 pass on 1.11. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Brings LightweightStats.jl onto the SciMLTesting
run_testsfolder model and moves QA onto the run_qa v1.6 form with ExplicitImports enabled.Changes
test/runtests.jl->using SciMLTesting; run_tests()(folder-discovery mode).test/test_groups.tomldeclaresCore(lts/1/pre, 3 OSes) +QA(lts/1, ubuntu).test/*.jlare auto-discovered. The inlinemean/median/var/... testsets that lived inruntests.jlmove totest/core_tests.jl;regression_tests.jlandinterface_tests.jlstay as Core files.test/qa/qa.jl=run_qa(LightweightStats; explicit_imports = true)with JET loaded. Replaces the hand-rolledtest/jet_tests.jl+test/explicit_imports_tests.jl.test/qa/Project.toml:SciMLTesting "1.6",JET,Test, andAquakept as a direct dep (Aqua's ambiguities child-process needs it).ExplicitImportsdropped (transitive via SciMLTesting).[targets].testgainsSciMLTesting+SafeTestsets(the@safetestsetwrapper the folder model uses needs SafeTestsets resolvable by name) and dropsExplicitImports+JET(now in the QA sub-env).PrecompileToolsfloor stays1.2(theusing PrecompileTools: @compile_workloadmacro-only import).Tests.ymlswitches togrouped-tests.yml@v1so QA runs as its own lane.ExplicitImports findings
Zero findings — no ignore-lists, no
ei_broken, no@test_broken. All 6 checks pass clean (no_implicit_imports,no_stale_explicit_imports,all_explicit_imports_via_owners,all_qualified_accesses_via_owners,all_qualified_accesses_are_public,all_explicit_imports_are_public). The package has zero non-stdlib runtime deps beyond PrecompileTools and only one self-qualifiedLightweightStats.meanaccess (benign; not a finding). JETreport_packageis clean (0 reports), so nojet_brokeneither.Verification (released SciMLTesting 1.6.0, no dev-from-branch)
core_tests69/69,interface_tests33/33,regression_tests322/322.🤖 Generated with Claude Code