Skip to content

QA: run_qa v1.6 form + ExplicitImports#31

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:qa-run_qa-v1.6-explicit-imports
Jun 25, 2026
Merged

QA: run_qa v1.6 form + ExplicitImports#31
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:qa-run_qa-v1.6-explicit-imports

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Collaborator

Ignore until reviewed by @ChrisRackauckas.

Brings LightweightStats.jl onto the SciMLTesting run_tests folder model and moves QA onto the run_qa v1.6 form with ExplicitImports enabled.

Changes

  • test/runtests.jl -> using SciMLTesting; run_tests() (folder-discovery mode).
  • test/test_groups.toml declares Core (lts/1/pre, 3 OSes) + QA (lts/1, ubuntu).
  • Core group: top-level test/*.jl are auto-discovered. The inline mean/median/var/... testsets that lived in runtests.jl move to test/core_tests.jl; regression_tests.jl and interface_tests.jl stay as Core files.
  • QA group: new test/qa/qa.jl = run_qa(LightweightStats; explicit_imports = true) with JET loaded. Replaces the hand-rolled test/jet_tests.jl + test/explicit_imports_tests.jl.
  • test/qa/Project.toml: SciMLTesting "1.6", JET, Test, and Aqua kept as a direct dep (Aqua's ambiguities child-process needs it). ExplicitImports dropped (transitive via SciMLTesting).
  • Root [targets].test gains SciMLTesting + SafeTestsets (the @safetestset wrapper the folder model uses needs SafeTestsets resolvable by name) and drops ExplicitImports + JET (now in the QA sub-env). PrecompileTools floor stays 1.2 (the using PrecompileTools: @compile_workload macro-only import).
  • CI Tests.yml switches to grouped-tests.yml@v1 so QA runs as its own lane.

ExplicitImports findings

Zero findings — no ignore-lists, no ei_broken, no @test_broken. All 6 checks pass clean (no_implicit_imports, no_stale_explicit_imports, all_explicit_imports_via_owners, all_qualified_accesses_via_owners, all_qualified_accesses_are_public, all_explicit_imports_are_public). The package has zero non-stdlib runtime deps beyond PrecompileTools and only one self-qualified LightweightStats.mean access (benign; not a finding). JET report_package is clean (0 reports), so no jet_broken either.

Verification (released SciMLTesting 1.6.0, no dev-from-branch)

  • QA group: 18/18 pass, 0 fail / 0 error / 0 broken on Julia 1.10 (lts) and 1.11 (1).
  • Core group on 1.11: core_tests 69/69, interface_tests 33/33, regression_tests 322/322.

🤖 Generated with Claude Code

Bring LightweightStats.jl onto the SciMLTesting run_tests folder model and
move QA onto the run_qa v1.6 form with ExplicitImports enabled.

- test/runtests.jl -> `using SciMLTesting; run_tests()` (folder discovery).
- test/test_groups.toml declares Core + QA (QA on lts/1, Core on lts/1/pre).
- Core group: the top-level test/*.jl are auto-discovered. The inline
  mean/median/var/... testsets that lived in runtests.jl move to
  test/core_tests.jl; regression_tests.jl and interface_tests.jl stay as Core
  files.
- QA group: new test/qa/qa.jl = `run_qa(LightweightStats; explicit_imports = true)`
  with JET loaded, replacing the hand-rolled test/jet_tests.jl and
  test/explicit_imports_tests.jl. All 6 ExplicitImports checks pass with no
  ignore-lists; JET report_package is clean; no @test_broken needed.
- test/qa/Project.toml: SciMLTesting "1.6", JET, Test, and Aqua kept as a
  direct dep so Aqua's ambiguities child-process can find it. ExplicitImports
  is dropped (transitive via SciMLTesting).
- Root [targets].test gains SciMLTesting + SafeTestsets (the @safetestset
  wrapper used by the folder model needs SafeTestsets resolvable by name) and
  drops ExplicitImports + JET (now in the QA sub-env). PrecompileTools floor
  stays 1.2 (the `using PrecompileTools: @compile_workload` macro-only import).
- CI Tests.yml switches to grouped-tests.yml@v1 so QA runs as its own lane.

Verified locally against released SciMLTesting 1.6.0: QA group 18/18 on
Julia 1.10 (lts) and 1.11 (1); Core group 69 + 33 + 322 pass on 1.11.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 25, 2026 16:36
@ChrisRackauckas ChrisRackauckas merged commit 99385b3 into SciML:main Jun 25, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants