Docs: keep dark-only widget previews dark - #62
Merged
Merged
Conversation
A widget with no light design rendered light on a light docs page. The card and the dark-only flag now come from the widget manifest, and the preview card colours match the product's.
Deploying stackyard-docs with
|
| Latest commit: |
a246832
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ef29ec5d.stackyard-docs.pages.dev |
| Branch Preview URL: | https://docs-dark-only-widget-previe.stackyard-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
widget.jsonwhen rendering a preview, in a sharedmanifestCardhelper used by bothWidgetPreviewandWidgetGroup. The card preset and the dark-only flag now come from the manifest instead of being passed per page or left unset.data-appearance="dark"on the preview card for Backup, GitHub, Disk Health and Now Playing, so they keep their dark card and dark interior on a light docs page, as they do on a light dashboard.#1c1c1ein dark and white in light, agraphitepreset for Disk Health, and no blur, replacing the old translucent glass.Testing
npm run buildandnpm run checkboth pass. Walked every widget page on the production build on port 4322 in Chrome, in both docs themes. The four dark-only widgets render identically in both, Disk Health sits on its graphite card with no strips at its sides, and the rest follow the docs theme as the dashboard follows Display Mode.Checklist
npm run buildandnpm run checkboth pass.