Feature: add service icons to widget service lists - #50
Merged
Merged
Conversation
Show a selfh.st icon beside each service in the widget pages, with a light and a dark variant that follow the page theme. Icons are served from public/icons/services.
Deploying stackyard-docs with
|
| Latest commit: |
4ac846e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://69b81833.stackyard-docs.pages.dev |
| Branch Preview URL: | https://feat-service-list-icons.stackyard-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iconfield toServiceListentries and render a 28px icon before the service name.data-theme; a.pngicon renders as a single image.public/icons/services/.iconon every service in the eight widget pages.Testing
All green. Checked icon alignment and theme switching in Chrome in both colour schemes, and the row layout at a 360px content width.
Checklist
npm run buildandnpm run checkboth pass.