Chore: add Worker static assets configuration - #4
Closed
SandObserver wants to merge 1 commit into
Closed
SandObserver wants to merge 1 commit into
SandObserver wants to merge 1 commit into
Conversation
Declares the built site as a static assets Worker so a Git-connected build can deploy it. Unmatched paths serve the generated 404 page. Verified with a dry run: 437 files read from the assets directory, no bindings.
SandObserver
added
the
github_actions
Owner
Author
|
Not needed. Cloudflare's Pages flow is available and does not read wrangler configuration, so this would be dead config. Revive if the project ever moves to a static assets Worker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrangler.jsoncdeclaring the built site as a static assets Worker, withnot_found_handling: "404-page"so unmatched paths serve the generated 404..wrangler/local state.Cloudflare's Git connection flow now provisions a Worker rather than a Pages
project, and
npx wrangler deployrequires this configuration to exist in therepository.
Testing
npm run checkpasses.wrangler deploy --dry-runreads 437 files from theassets directory and reports no bindings.
Checklist
npm run buildandnpm run checkboth pass.