Fix: give the tab icon its own background - #35
Merged
Merged
Conversation
Safari uses the light-scheme fill whatever the appearance, and supplies a light plate on macOS and none on iOS, so the same file rendered three ways. The mark now sits on the #0D1117 tile the PNG icons already use.
SandObserver
added
bug
Deploying stackyard-docs with
|
| Latest commit: |
bcbef3d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://027973fd.stackyard-docs.pages.dev |
| Branch Preview URL: | https://fix-favicon-safari-contrast.stackyard-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefers-color-schemefill inpublic/favicon.svgwith a fixed light mark on a#0D1117rounded tile, matchingtheme-color, the PNG icons and the app repository's copy of the same file.Testing
npm run buildandnpm run checkboth pass. The icon no longer depends on a colour scheme: the file carries no media query and two fixed fills, so it renders identically in both schemes and both docs themes. Checked in Chrome; the mark's position was verified by rendering the SVG andfavicon.pngat 1024 and comparing bounding boxes, which match at 653x690 from 189,162.Checklist
npm run buildandnpm run checkboth pass.