Fix: keep preview frame content out of the tab order - #34
Merged
Merged
Conversation
The Now Playing previews received an href in their static config, so the widget promoted its root to role="link" with tabindex="0". That content sat inside an iframe carrying tabindex="-1" and was unreachable by keyboard, failing WCAG 2.1.1. Drop href from the four preview configs used in tabindex="-1" frames, and clear the wordmark alt text that duplicated the visually hidden site title.
Deploying stackyard-docs with
|
| Latest commit: |
23b15bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bb44a2d8.stackyard-docs.pages.dev |
| Branch Preview URL: | https://fix-frame-focusable-content.stackyard-docs.pages.dev |
Drop href from the np-plex, np-jellyfin and np-emby preview configs. Each preview was a keyboard tab stop whose only action opened a placeholder domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hreffrom thew-nowplayingandcc-np-a/b/cpreview configs so the Now Playing widget no longer setsrole="link"andtabindex="0"on its root inside atabindex="-1"iframe.hreffrom thenp-plex,np-jellyfinandnp-embypreview configs so the widget-page previews are no longer keyboard tab stops that open a placeholder domain.altto an empty string;replacesTitlealready renders a visually hidden site title.Testing
All green:
npm run buildandnpm run checkpass. Re-ran axe-core (wcag2a/aa, wcag21a/aa, wcag22aa, best-practice) against the production build on the landing page,/docs/is-stackyard-for-you/,/docs/widgets/,/docs/widgets/now-playing/,/docs/widgets/clock/,/docs/widgets/weather/and/docs/installation/docker/, and inspected each iframe document directly: no focusable nodes remain in any preview frame, and no violations reported.Checklist
npm run buildandnpm run checkboth pass.https://claude.ai/code/session_011JKjAEDFmY6gSqC4td9twQ