Fix: raise footer contrast and preload the LCP wallpaper - #31
Merged
Merged
Conversation
Preload /img/wallpaper.jpg so the mockup background is requested from the document head instead of after the stylesheet parses. Raise .license and .foot-links span to rgba(255,255,255,.5) and darken the version badge to #0072b5, bringing all three above the 4.5 contrast minimum.
Deploying stackyard-docs with
|
| Latest commit: |
2b3ad74
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a2ec102.stackyard-docs.pages.dev |
| Branch Preview URL: | https://fix-footer-contrast-and-lcp.stackyard-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/img/wallpaper.jpgas an image from the document head so the LCP background on.screen::beforeis requested by the preload scanner instead of afterindex.cssparses..licensefromrgba(255,255,255,.45)to.5(4.41 to 5.28 against the black footer)..foot-links spanseparators fromrgba(255,255,255,.28)to.5(2.27 to 5.28)..verbadge bbackground from#007ec6to#0072b5(4.38 to 5.15 against white text).Testing
All green:
npm run buildandnpm run checkboth pass. Verified in Chrome againstastro preview: the wallpaper request now has alinkinitiator and starts at 35ms, and all four footer nodes measure at or above 4.5.Checklist
npm run buildandnpm run checkboth pass.