Fix: open the demo links in a new tab - #23
Merged
Merged
Conversation
The landing page is not markdown, so the external-link rehype plugin never reaches it and both demo links replaced the page.
Deploying stackyard-docs with
|
| Latest commit: |
3c38b07
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6cb09eb8.stackyard-docs.pages.dev |
| Branch Preview URL: | https://fix-demo-link-new-tab.stackyard-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target="_blank"andrel="noopener noreferrer"to the hero Demo button and the footer Demo link on the landing page.Testing
All green:
npm run buildandnpm run checkboth pass. Verified in Chrome that the Demo button opens a second tab and leaves the landing page in place.Checklist
npm run buildandnpm run checkboth pass.