Fix: give the landing page badges the product's capsule corner - #20
Merged
Merged
Conversation
Both badge rules computed a radius of exactly half the pill's height, on a height that is scaled by a fraction. WebKit tears the rounded edge when such a badge repaints, and the demo counter rewrites it every 3.4 seconds.
Deploying stackyard-docs with
|
| Latest commit: |
d43c3d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://933d6520.stackyard-docs.pages.dev |
| Branch Preview URL: | https://fix-badge-capsule-corner.stackyard-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
border-radiuson.badgeand on the hero's scaled.screen-inner .badgewith the fixed capsule radius the dashboard's own badge uses.Testing
npm run buildandnpm run checkboth pass. Checked in Chrome against the production build on 4322: the badges are unchanged in shape at both scales. The artifact this addresses is a GPU compositing fault that does not reproduce in headless WebKit, so it needs confirming in Safari.Checklist
npm run buildandnpm run checkboth pass.