Chore: gate credentials and private addresses in the check script - #2
Merged
Merged
Conversation
Adds a secrets check over the files this repository authors, covering token shapes for several providers, private key blocks, JWTs, and RFC 1918 addresses. Documented examples in prose are allowed; stub payloads and page sources are not. Skips binary files in the hygiene scan. Byte sequences in images were matching the word list and would have failed CI for no reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secretscheck toscripts/check-dist.mjsoversrc/andpublic/api/, the files this repository authors. Covers GitHub, OpenAI-shaped,AWS, Google and Slack token patterns, private key blocks, JWTs, and RFC 1918
addresses. Private addresses stay allowed in Markdown prose, where they are
documented examples.
public/js/andpublic/widgets/are excluded: they are verbatim copies of theapplication and carry its own placeholder values.
Testing
npm run buildandnpm run checkpass. Verified the gate by planting a fakeGitHub token and a
192.168.1.42address in a stub payload: both were reportedand the run failed. Removing them restored a pass.
Checklist
npm run buildandnpm run checkboth pass.