Fix: finish the logo redraw across every surface - #337
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logosprite symbol in--label-primaryink and the theme accent, and removebrand-mark.jswith its hard-coded#F2F2F7strokes.<use href="#sy-solid-logo">.templates/icon.svg,icon-light.svgandicon-dark.svgfor the favicon geometry, keeping each file's plate and placement.favicon-maskable.pngas a full-bleed#0D1117square with the logo inside the 80% safe zone, instead of a copy offavicon-512.png.logoIcon().Testing
All green, including e2e and the Docker build. Added tests that decode the maskable PNG and check its opaque background outside the safe zone; measure painted logo and docs-icon bounds with arcs and round ends; check one accent part per docs icon; and pin the favicon and Unraid icons to the
logoIcon()geometry.Changelog
Fixed
Checklist